Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_eks_addon: Add default tags support #18871

Merged
merged 2 commits into from
Apr 25, 2021

Conversation

gdavison
Copy link
Contributor

Adds default tags support for aws_eks_addon

Relates #7926
Relates #16972

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEksAddon_'

--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag (50.46s)
--- PASS: TestAccAWSEksAddon_disappears (927.88s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToProviderOnly (994.27s)
--- PASS: TestAccAWSEksAddon_disappears_Cluster (1035.77s)
--- PASS: TestAccAWSEksAddon_ServiceAccountRoleArn (1061.19s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToResourceOnly (1111.52s)
--- PASS: TestAccAWSEksAddon_AddonVersion (1115.52s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag (1116.04s)
--- PASS: TestAccAWSEksAddon_ignoreTags (1148.55s)
--- PASS: TestAccAWSEksAddon_Tags (1153.86s)
--- PASS: TestAccAWSEksAddon_basic (1159.40s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag (1204.30s)
--- PASS: TestAccAWSEksAddon_ResolveConflicts (1211.20s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerOnly (1225.17s)
--- PASS: TestAccAWSEksAddon_defaultAndIgnoreTags (1239.23s)

@gdavison gdavison requested a review from a team as a code owner April 15, 2021 00:13
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a small documentation note.

@gdavison gdavison merged commit ccd6c9b into main Apr 25, 2021
@gdavison gdavison deleted the eks-cluster-addons-default-tags branch April 25, 2021 04:49
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 25, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants