Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws-sdk-go/service/shield package #1901

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add aws-sdk-go/service/shield package #1901

merged 2 commits into from
Oct 16, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

For #1899

govendor fetch github.com/aws/aws-sdk-go/service/shield

@atsushi-ishibashi atsushi-ishibashi mentioned this pull request Oct 15, 2017
Closed
radeksimko
radeksimko reviewed Oct 15, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating this. Would you mind pinning shield to a version? Ideally the same one we use for the rest of the AWS SDK, that is v1.12.8:

govendor fetch github.com/aws/aws-sdk-go/service/shield@v1.12.8

@radeksimko radeksimko added dependencies Used to indicate dependency changes. waiting-response Maintainers are waiting on response from community or contributor. labels Oct 15, 2017
@atsushi-ishibashi
Copy link
Contributor Author

@radeksimko Sure👍

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 16, 2017
@radeksimko radeksimko merged commit eaf717c into hashicorp:master Oct 16, 2017
@atsushi-ishibashi atsushi-ishibashi deleted the add-shield-package branch December 13, 2017 15:16
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko left review comments

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi-ishibashi @radeksimko