Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables tfproviderlint rule AT010 #19218

Merged
merged 1 commit into from
May 5, 2021
Merged

Enables tfproviderlint rule AT010 #19218

merged 1 commit into from
May 5, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 3, 2021

ID-only refresh tests are no longer needed now that import testing is available. Enables the tfproviderlint rule AT010 to remove ID-only refresh tests.

Closes #18354

@gdavison gdavison requested a review from a team as a code owner May 3, 2021 23:49
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 3, 2021
@ewbankkit ewbankkit self-assigned this May 4, 2021
ewbankkit
ewbankkit approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make awsproviderlint

@ewbankkit ewbankkit removed their assignment May 4, 2021
@gdavison gdavison merged commit 4d129cb into main May 5, 2021
@gdavison gdavison deleted the remove-id-only-linter branch May 5, 2021 00:32
@github-actions github-actions bot added this to the v3.39.0 milestone May 5, 2021
github-actions bot pushed a commit that referenced this pull request May 5, 2021
Update CHANGELOG.md for #19218
5cb91eb
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.39.0
Development

Successfully merging this pull request may close these issues.

tests/provider: Remove ID-Only Refresh Testing (Fix and Enable tfproviderlint AT010 and AT011)
2 participants
@gdavison @ewbankkit