Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/resource aws pinpoint email channel #19361

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented May 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19318.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_noRole'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_noRole -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.37
=== RUN   TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== CONT  TestAccAWSPinpointEmailChannel_noRole
--- PASS: TestAccAWSPinpointEmailChannel_noRole (49.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.912s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner May 13, 2021 14:57
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/pinpoint Issues and PRs that pertain to the pinpoint service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 13, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 13, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label May 13, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 14, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels May 14, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_ -timeout 180m
=== RUN   TestAccAWSPinpointEmailChannel_basic
=== PAUSE TestAccAWSPinpointEmailChannel_basic
=== RUN   TestAccAWSPinpointEmailChannel_configurationSet
=== PAUSE TestAccAWSPinpointEmailChannel_configurationSet
=== RUN   TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== RUN   TestAccAWSPinpointEmailChannel_disappears
=== PAUSE TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_basic
=== CONT  TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_configurationSet
=== CONT  TestAccAWSPinpointEmailChannel_noRole
--- PASS: TestAccAWSPinpointEmailChannel_disappears (16.16s)
--- PASS: TestAccAWSPinpointEmailChannel_noRole (16.59s)
--- PASS: TestAccAWSPinpointEmailChannel_configurationSet (17.45s)
--- PASS: TestAccAWSPinpointEmailChannel_basic (31.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.131s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSPinpointEmailChannel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSPinpointEmailChannel_ -timeout 180m
=== RUN   TestAccAWSPinpointEmailChannel_basic
=== PAUSE TestAccAWSPinpointEmailChannel_basic
=== RUN   TestAccAWSPinpointEmailChannel_configurationSet
=== PAUSE TestAccAWSPinpointEmailChannel_configurationSet
=== RUN   TestAccAWSPinpointEmailChannel_noRole
=== PAUSE TestAccAWSPinpointEmailChannel_noRole
=== RUN   TestAccAWSPinpointEmailChannel_disappears
=== PAUSE TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_basic
=== CONT  TestAccAWSPinpointEmailChannel_disappears
=== CONT  TestAccAWSPinpointEmailChannel_noRole
=== CONT  TestAccAWSPinpointEmailChannel_configurationSet
--- PASS: TestAccAWSPinpointEmailChannel_disappears (23.00s)
--- PASS: TestAccAWSPinpointEmailChannel_configurationSet (24.49s)
--- PASS: TestAccAWSPinpointEmailChannel_noRole (24.89s)
--- PASS: TestAccAWSPinpointEmailChannel_basic (42.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.477s

@ewbankkit ewbankkit merged commit aefd129 into hashicorp:main May 14, 2021
@github-actions github-actions bot added this to the v3.41.0 milestone May 14, 2021
@ghost
Copy link

ghost commented May 19, 2021

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@nikhil-goenka nikhil-goenka deleted the f/resource_aws_pinpoint_email_channel branch May 25, 2021 05:54
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/pinpoint Issues and PRs that pertain to the pinpoint service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_pinpoint_email_channel requires Role arn which is optional in cloudformation
2 participants