Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fixed import parameter in aws_dms_certificate #19461

Merged
merged 1 commit into from
May 21, 2021
Merged

Documentation: fixed import parameter in aws_dms_certificate #19461

merged 1 commit into from
May 21, 2021

Conversation

kangaechu
Copy link
Contributor

When importing aws_dms_certificate, the argument listed in the documentation is certificate_arn, but certificate_id is correct.

https://github.com/kangaechu/terraform-provider-aws/blob/7900b33d47fe9f26c0fb23f9672f3354dce7b734/aws/resource_aws_dms_certificate.go#L88-L95

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Closes #19460

@kangaechu kangaechu requested a review from a team as a code owner May 21, 2021 03:21
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 21, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/databasemigrationservice labels May 21, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit merged commit d055ffd into hashicorp:main May 21, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 21, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: aws_dms_certificate import parameter use certificate_id instead of certificate_arn.
2 participants