Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_lambda_invocation #19488

Merged
merged 19 commits into from
Jan 20, 2022

Conversation

pascal-cosmic-cloud
Copy link

@pascal-cosmic-cloud pascal-cosmic-cloud commented May 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4746

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccResourceAwsLambdaInvocation_basic'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccResourceAwsLambdaInvocation_basic -timeout 180m
=== RUN   TestAccResourceAwsLambdaInvocation_basic
=== PAUSE TestAccResourceAwsLambdaInvocation_basic
=== CONT  TestAccResourceAwsLambdaInvocation_basic
--- PASS: TestAccResourceAwsLambdaInvocation_basic (67.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.134s
$ make testacc TESTARGS='-run=TestAccResourceAwsLambdaInvocation_qualifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccResourceAwsLambdaInvocation_qualifier -timeout 180m
=== RUN   TestAccResourceAwsLambdaInvocation_qualifier
=== PAUSE TestAccResourceAwsLambdaInvocation_qualifier
=== CONT  TestAccResourceAwsLambdaInvocation_qualifier
--- PASS: TestAccResourceAwsLambdaInvocation_qualifier (70.58s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       72.298s
$ make testacc TESTARGS='-run=TestAccResourceAwsLambdaInvocation_complex'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccResourceAwsLambdaInvocation_complex -timeout 180m
=== RUN   TestAccResourceAwsLambdaInvocation_complex
=== PAUSE TestAccResourceAwsLambdaInvocation_complex
=== CONT  TestAccResourceAwsLambdaInvocation_complex
--- PASS: TestAccResourceAwsLambdaInvocation_complex (67.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       68.750s
$ make testacc TESTARGS='-run=TestAccResourceAwsLambdaInvocation_Triggers'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccResourceAwsLambdaInvocation_Triggers -timeout 180m
=== RUN   TestAccResourceAwsLambdaInvocation_Triggers
=== PAUSE TestAccResourceAwsLambdaInvocation_Triggers
=== CONT  TestAccResourceAwsLambdaInvocation_Triggers
--- PASS: TestAccResourceAwsLambdaInvocation_Triggers (158.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       160.289s

All credits to dedunumax #14388 (I am just fixing a stale PR)

@pascal-cosmic-cloud pascal-cosmic-cloud requested a review from a team as a code owner May 24, 2021 06:41
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label May 24, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 24, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pascal236 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@agseijas
Copy link

Dunno if it can be done without changes to this PR, what about changing the input on tf destroy phase?

@dedunumax
Copy link
Contributor

@DJAlPee Thanks a lot for your swift review. Can we merge this before it gets stale again?

@DJAlPee
Copy link

DJAlPee commented Jul 8, 2021

Sorry, but I'm not a member of Hashicorp/Terraform team (yet) 😄.
No idea, how to ping a maintainer...

@pascal-cosmic-cloud
Copy link
Author

If anyone knows how to push/notify this to one of the terraform-aws reviewer, please let me know :)

@avivek
Copy link

avivek commented Jul 21, 2021

Is this on the radar??
It will be absolutely useful for our workflows.

@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@YakDriver YakDriver added the pre-service-packages Includes pre-Service Packages aspects. label Nov 30, 2021
@YakDriver YakDriver self-assigned this Jan 18, 2022
@YakDriver YakDriver added this to the Roadmap milestone Jan 18, 2022
@github-actions github-actions bot removed the pre-service-packages Includes pre-Service Packages aspects. label Jan 20, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Output of acceptance tests (us-west-2):

% make testacc TESTS=TestAccLambdaInvocation_ PKG=lambda                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocation_'  -timeout 180m
--- PASS: TestAccLambdaInvocation_basic (31.34s)
--- PASS: TestAccLambdaInvocation_qualifier (45.57s)
--- PASS: TestAccLambdaInvocation_complex (53.02s)
--- PASS: TestAccLambdaInvocation_triggers (68.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	69.753s

Output of acceptance tests (GovCloud):

% make testacc TESTS=TestAccLambdaInvocation_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocation_'  -timeout 180m
--- PASS: TestAccLambdaInvocation_basic (33.75s)
--- PASS: TestAccLambdaInvocation_qualifier (40.24s)
--- PASS: TestAccLambdaInvocation_complex (46.88s)
--- PASS: TestAccLambdaInvocation_triggers (91.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	92.475s

@YakDriver YakDriver merged commit 14a8b6f into hashicorp:main Jan 20, 2022
@github-actions github-actions bot modified the milestones: Roadmap, v3.73.0 Jan 20, 2022
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execute aws_lambda_invocation only once
8 participants