Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds/servicecatalog_product: New data source #19503

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogProductDataSource_basic (37.51s)
--- PASS: TestAccAWSServiceCatalogProductDataSource_physicalID (117.15s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogProductDataSource_basic (29.89s)
--- PASS: TestAccAWSServiceCatalogProductDataSource_physicalID (72.84s)

@YakDriver YakDriver requested a review from a team as a code owner May 24, 2021 18:17
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label May 24, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 24, 2021
@bill-rich bill-rich self-requested a review June 16, 2021 22:23
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogProductDataSource_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.45
=== RUN   TestAccAWSServiceCatalogProductDataSource_basic
=== PAUSE TestAccAWSServiceCatalogProductDataSource_basic
=== RUN   TestAccAWSServiceCatalogProductDataSource_physicalID
=== PAUSE TestAccAWSServiceCatalogProductDataSource_physicalID
=== CONT  TestAccAWSServiceCatalogProductDataSource_basic
=== CONT  TestAccAWSServiceCatalogProductDataSource_physicalID
--- PASS: TestAccAWSServiceCatalogProductDataSource_basic (24.69s)
--- PASS: TestAccAWSServiceCatalogProductDataSource_physicalID (69.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.456s

@YakDriver YakDriver merged commit 030defd into main Jun 22, 2021
@YakDriver YakDriver deleted the f-servicecat-ds-product branch June 22, 2021 17:07
@YakDriver YakDriver added this to the v3.47.0 milestone Jun 22, 2021
github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants