Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/iam_role - add plan time validations #19532

Closed
wants to merge 2 commits into from

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMRole_'
--- PASS: TestAccAWSIAMRole_badJSON (19.51s)
--- PASS: TestAccAWSIAMRole_disappears (52.30s)
--- PASS: TestAccAWSIAMRole_policyBasicInlineEmpty (54.28s)
--- PASS: TestAccAWSIAMRole_basic (56.15s)
--- PASS: TestAccAWSIAMRole_namePrefix (58.30s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (66.71s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_managedNonExistent (85.92s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedEmpty (90.30s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineEmpty (91.42s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_inlineNonEmpty (92.20s)
--- PASS: TestAccAWSIAMRole_tags (93.65s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_inlineNonEmpty (97.30s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (98.48s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionRemoved_managedNonEmpty (101.40s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandRemovalAddedBack_managedNonEmpty (101.58s)
--- PASS: TestAccAWSIAMRole_testNameChange (111.15s)
--- PASS: TestAccAWSIAMRole_policyOutOfBandAdditionIgnored_inlineNonExistent (115.37s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (111.60s)
--- PASS: TestAccAWSIAMRole_policyBasicManaged (134.77s)
--- PASS: TestAccAWSIAMRole_policyBasicInline (134.87s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (171.22s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner May 26, 2021 13:58
@ghost ghost added size/S Managed by automation to categorize the size of a PR. labels May 26, 2021
@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 26, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 10, 2021
@DrFaust92 DrFaust92 force-pushed the r/iam_role_validations branch from ef9a3ba to bba656f Compare September 10, 2021 16:56
@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.
I included your changes in #20785.

@ewbankkit ewbankkit closed this Sep 10, 2021
@DrFaust92 DrFaust92 deleted the r/iam_role_validations branch September 10, 2021 19:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants