Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweepers/subnet: add networkfirewall firewall to dependencies #19866

Merged
merged 1 commit into from
Jun 18, 2021
Merged

sweepers/subnet: add networkfirewall firewall to dependencies #19866

merged 1 commit into from
Jun 18, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 17, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16301

Output from acceptance testing:

will be verified by nightly TC runs

@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 17, 2021
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. and removed service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 17, 2021
@anGie44 anGie44 changed the title sweepers/subnet: add networkfirewall firewall to dependendies sweepers/subnet: add networkfirewall firewall to dependencies Jun 17, 2021
ewbankkit
ewbankkit approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Verified that aws_networkfirewall_firewall sweeper only depends on aws_networkfirewall_logging_configuration sweeper which has no dependencies.

@anGie44 anGie44 added this to the v3.47.0 milestone Jun 18, 2021
@anGie44 anGie44 merged commit 842164d into main Jun 18, 2021
@anGie44 anGie44 deleted the td-subnet-sweeper-dep branch June 18, 2021 17:30
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit