-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket_intelligent_tiering_configuration: New Resource #20329
r/s3_bucket_intelligent_tiering_configuration: New Resource #20329
Conversation
how will be it work if you setup many policies for different folders? I think configuration for specific folder should in included in namespace for this folder. |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
Acceptance test output: % make testacc PKG_NAME=internal/service/s3 TESTARGS='-run=TestAccS3BucketIntelligentTieringConfiguration_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketIntelligentTieringConfiguration_ -timeout 180m === RUN TestAccS3BucketIntelligentTieringConfiguration_basic === PAUSE TestAccS3BucketIntelligentTieringConfiguration_basic === RUN TestAccS3BucketIntelligentTieringConfiguration_disableBasic === PAUSE TestAccS3BucketIntelligentTieringConfiguration_disableBasic === RUN TestAccS3BucketIntelligentTieringConfiguration_updateBasic === PAUSE TestAccS3BucketIntelligentTieringConfiguration_updateBasic === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Empty === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Empty === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Prefix === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Prefix === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_SingleTag === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_SingleTag === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_MultipleTags === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_MultipleTags === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_PrefixAndTags === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_PrefixAndTags === RUN TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Remove === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Remove === RUN TestAccS3BucketIntelligentTieringConfiguration_WithTier_Empty === PAUSE TestAccS3BucketIntelligentTieringConfiguration_WithTier_Empty === CONT TestAccS3BucketIntelligentTieringConfiguration_basic === CONT TestAccS3BucketIntelligentTieringConfiguration_WithTier_Empty === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_SingleTag === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_MultipleTags === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Remove === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_PrefixAndTags === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Empty === CONT TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Prefix === CONT TestAccS3BucketIntelligentTieringConfiguration_disableBasic === CONT TestAccS3BucketIntelligentTieringConfiguration_updateBasic --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithTier_Empty (3.00s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Empty (3.18s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (34.85s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_MultipleTags (60.70s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Prefix (60.70s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_Remove (60.72s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_disableBasic (60.72s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_SingleTag (60.72s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_WithFilter_PrefixAndTags (60.75s) --- PASS: TestAccS3BucketIntelligentTieringConfiguration_updateBasic (86.88s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 90.313s
35e7d6c
to
9a3dcbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG_NAME=internal/service/s3 TESTARGS='-run=TestAccS3BucketIntelligentTieringConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketIntelligentTieringConfiguration_ -timeout 180m
=== RUN TestAccS3BucketIntelligentTieringConfiguration_basic
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_basic
=== RUN TestAccS3BucketIntelligentTieringConfiguration_disappears
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_disappears
=== RUN TestAccS3BucketIntelligentTieringConfiguration_Filter
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_Filter
=== CONT TestAccS3BucketIntelligentTieringConfiguration_basic
=== CONT TestAccS3BucketIntelligentTieringConfiguration_Filter
=== CONT TestAccS3BucketIntelligentTieringConfiguration_disappears
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (25.23s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (27.99s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (107.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 111.337s
GovCloud
% make testacc PKG_NAME=internal/service/s3 TESTARGS='-run=TestAccS3BucketIntelligentTieringConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3BucketIntelligentTieringConfiguration_ -timeout 180m
=== RUN TestAccS3BucketIntelligentTieringConfiguration_basic
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_basic
=== RUN TestAccS3BucketIntelligentTieringConfiguration_disappears
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_disappears
=== RUN TestAccS3BucketIntelligentTieringConfiguration_Filter
=== PAUSE TestAccS3BucketIntelligentTieringConfiguration_Filter
=== CONT TestAccS3BucketIntelligentTieringConfiguration_basic
=== CONT TestAccS3BucketIntelligentTieringConfiguration_Filter
=== CONT TestAccS3BucketIntelligentTieringConfiguration_disappears
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (28.16s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (31.24s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (126.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 130.097s
@daniepett Thanks for the contribution 🎉 👏. |
% make golangci-lint
==> Checking source code with golangci-lint... |
This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #16123
Example
Output from acceptance testing: