Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id field from aws_servicecatalog_portfolio #2065

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

radeksimko
Copy link
Member

id field is not required in the schema, similar to #1626

Next up is upgrading vendored hashicorp/terraform which has validation for this and should prevent resources with id in schema from coming up in the future.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Oct 26, 2017
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 6b2f18b into master Oct 26, 2017
@radeksimko radeksimko deleted the b-servicecatalog-id-field-removal branch November 12, 2017 21:20
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants