Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: ECR Lifecycle Policy #2096

Merged
merged 3 commits into from
Oct 29, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

@atsushi-ishibashi atsushi-ishibashi commented Oct 29, 2017

#1868

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcrLifecyclePolicy_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcrLifecyclePolicy_basic -timeout 120m
=== RUN   TestAccAWSEcrLifecyclePolicy_basic
--- PASS: TestAccAWSEcrLifecyclePolicy_basic (36.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.287s

Closes #1869
Closes #1868

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@radeksimko radeksimko merged commit ad3cd79 into hashicorp:master Oct 29, 2017
@OJFord
Copy link

OJFord commented Nov 19, 2017

It seems that this doesn't actually apply the policy; only adds it in a sort of 'draft' state, is that correct?

If I login to the console I can use it to perform dry runs, but I have to click 'apply lifecycle policy' to have it do anything.

Looking at the API though, I'm not sure it's even possible - it seems you can start and review dry runs via the API, but not actually apply the policy. 😕

@atsushi-ishibashi atsushi-ishibashi deleted the issue1868-revise branch December 13, 2017 15:16
@rafilkmp3
Copy link

so if its merged how I can use this ? the official documentation isn't updated.

@bflad
Copy link
Contributor

bflad commented Jan 26, 2018

@rafilkmp3 the documentation for this resource can be found at: https://www.terraform.io/docs/providers/aws/r/ecr_lifecycle_policy.html

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support lifecycle policy for ECR
5 participants