-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource for AppStream User and Stack User Association #21485
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
97eba2f
feat: added resource and docs for appstream user
b04cd2a
feat: added resource and docs for appstream stack user association
f2153b4
fixes typo
d4e86d4
fixes typo
0f5c08c
added changelog
02f8d79
fixes github linter
dd0cdf7
refactor: updated with the suggestions of gdavison
coderGo93 fb6211b
updated doc
coderGo93 e1f40db
updated doc
coderGo93 345127f
fixes linter
coderGo93 969b46c
Returns `resource.NotFoundError` from `FindUserByUserNameAndAuthType()`
gdavison 40e7c23
refactor
coderGo93 05f8b76
refactor: updated the way for enabled
coderGo93 0e679c6
refactor
coderGo93 7feebdd
Error message tweaks
gdavison 276fa7b
Uses random domain for acceptance tests
gdavison b0e4952
Uses finder function for AppStream User
gdavison 66edfcd
Reorders test steps since step 1 and 2 were the same
gdavison 9e7b10a
Re-orders generated User Stack Association ID so that Username and Au…
gdavison f130d56
Skips User tests in unsupported regions and partitions
gdavison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
```release-note:new-resource | ||
aws_appstream_user | ||
``` | ||
|
||
```release-note:new-resource | ||
aws_appstream_stack_user_association | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we move handling not-found into this function, then calling functions can be simpler. For instance, here, we can check the following before other errors
And then, after looping over the results, if
user
isnil
Then, in code that calls this function, it can simply check for a not found error by using the function
tfresource.NotFound(err)
See https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ds/find.go for an example