Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: r/ecs_task_definition note about quote escaping container_definition #2162

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 2, 2017

This is a targeted documentation note, but maybe it could be put somewhere more generic and referenced in various places where the Terraform/API input is raw JSON for a field and could contain quotes in values?

Closes #2142

@Ninir
Copy link
Contributor

Ninir commented Nov 3, 2017

Hi @bflad

Good call! :)

I do think this would have sense in the interpolation documentation for instance, and then link notes in other pages to it. Thoughts? :)

@Ninir Ninir added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 3, 2017
@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Nov 7, 2017
@radeksimko radeksimko added the size/XS Managed by automation to categorize the size of a PR. label Nov 15, 2017
@catsby
Copy link
Contributor

catsby commented Dec 18, 2017

Added to the Interpolation docs in hashicorp/terraform#16940

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@catsby catsby merged commit a0ec23c into hashicorp:master Dec 18, 2017
@bflad bflad deleted the ecs_task_definition_note branch December 18, 2017 17:28
@bflad
Copy link
Contributor Author

bflad commented Dec 18, 2017

💯 🎉

catsby added a commit that referenced this pull request Dec 19, 2017
* master: (147 commits)
  Cleaned Data Sources
  Update CHANGELOG.md
  resource/cognito_user_pool: Update Cognito email message length to 20,000 (#2692)
  Update ecs_service.html.markdown (#2694)
  Documentation: r/ecs_task_definition note about quote escaping container_definition (#2162)
  Cleanup after v1.6.0 release
  v1.6.0
  Make depends_on consistent with note (#2526)
  removing duplicate
  Update CHANGELOG.md
  r/aws_ssm_parameter: Fix arn attribute for full path names and improve testing
  Update CHANGELOG.md
  Update CHANGELOG.md
  s3: Add validation for SSE Algorithm and correct spelling
  #2217: fixed when encryption is AES256
  #2217: documentation
  #2217: re-enable default encryption after disabling in via UI
  #2217: wrote additional acceptance test
  #2217: wrote typical acceptance test
  #2217: make fmt
  ...
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform ECS task environment variable with json
5 participants