Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws rds cluster activity stream #21662

Closed

Conversation

jdstuart
Copy link
Contributor

@jdstuart jdstuart commented Nov 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description: This PR adds support for the Amazon Aurora Database Activity Streams.

Credit goes to the original author of #14243 for his contributions.


Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSRDSClusterActivityStream_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterActivityStream_ -timeout 120m
=== RUN   TestAccAWSRDSClusterActivityStream_basic
=== PAUSE TestAccAWSRDSClusterActivityStream_basic
=== RUN   TestAccAWSRDSClusterActivityStream_disappears
=== PAUSE TestAccAWSRDSClusterActivityStream_disappears
=== RUN   TestAccAWSRDSClusterActivityStream_kmsKeyId
=== PAUSE TestAccAWSRDSClusterActivityStream_kmsKeyId
=== RUN   TestAccAWSRDSClusterActivityStream_mode
=== PAUSE TestAccAWSRDSClusterActivityStream_mode
=== RUN   TestAccAWSRDSClusterActivityStream_resourceArn
=== PAUSE TestAccAWSRDSClusterActivityStream_resourceArn
=== CONT  TestAccAWSRDSClusterActivityStream_basic
=== CONT  TestAccAWSRDSClusterActivityStream_resourceArn
=== CONT  TestAccAWSRDSClusterActivityStream_kmsKeyId
=== CONT  TestAccAWSRDSClusterActivityStream_mode
=== CONT  TestAccAWSRDSClusterActivityStream_disappears
--- PASS: TestAccAWSRDSClusterActivityStream_disappears (1257.30s)
--- PASS: TestAccAWSRDSClusterActivityStream_basic (1718.78s)
--- PASS: TestAccAWSRDSClusterActivityStream_mode (2176.32s)
--- PASS: TestAccAWSRDSClusterActivityStream_kmsKeyId (2043.42s)
--- PASS: TestAccAWSRDSClusterActivityStream_resourceArn (2513.59s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2539.247s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. pre-service-packages Includes pre-Service Packages aspects. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jdstuart 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jdstuart jdstuart changed the title F aws rds cluster activity stream New Resource: aws rds cluster activity stream Nov 9, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 10, 2021
@jdstuart jdstuart closed this Dec 7, 2021
@jdstuart jdstuart deleted the f-aws_rds_cluster_activity_stream branch December 7, 2021 22:30
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. pre-service-packages Includes pre-Service Packages aspects. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants