Allow empty values in Service Catalog provisioning parameters

[wedge-jarrad]

Remove check for empty value in order to allow an empty string to pass through
to the CloudFormation template.

Update tests to use provisioning parameters in order to exercise this
functionality.

Not 100% sure that adding provisioning_parameters to the ImportStateVerifyIgnore list is the right thing to do here, but modifying the resourceProvisionedProductRead function to set those values seems beyond the scope of this bug fix.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21349

Output from acceptance testing after modifying tests but before applying the fix:

$ gmake testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct' PKG_NAME=internal/service/servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run=TestAccServiceCatalogProvisionedProduct -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
    provisioned_product_test.go:26: Step 1/2 error: Error running apply: exit status 1
        
        Error: error describing Service Catalog Provisioned Product (pp-qfufhnc642yu2): unexpected state 'ERROR', wanted target 'AVAILABLE'. last error: %!s(<nil>)
        
          with aws_servicecatalog_provisioned_product.test,
          on terraform_plugin_test.tf line 120, in resource "aws_servicecatalog_provisioned_product" "test":
         120: resource "aws_servicecatalog_provisioned_product" "test" {
        
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
    provisioned_product_test.go:72: Step 1/1 error: Error running apply: exit status 1
        
        Error: error describing Service Catalog Provisioned Product (pp-wryjotbcjnlnm): unexpected state 'ERROR', wanted target 'AVAILABLE'. last error: %!s(<nil>)
        
          with aws_servicecatalog_provisioned_product.test,
          on terraform_plugin_test.tf line 120, in resource "aws_servicecatalog_provisioned_product" "test":
         120: resource "aws_servicecatalog_provisioned_product" "test" {
        
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
    provisioned_product_test.go:96: Step 1/2 error: Error running apply: exit status 1
        
        Error: error describing Service Catalog Provisioned Product (pp-cmduouhf6ta4u): unexpected state 'ERROR', wanted target 'AVAILABLE'. last error: %!s(<nil>)
        
          with aws_servicecatalog_provisioned_product.test,
          on terraform_plugin_test.tf line 120, in resource "aws_servicecatalog_provisioned_product" "test":
         120: resource "aws_servicecatalog_provisioned_product" "test" {
        
--- FAIL: TestAccServiceCatalogProvisionedProduct_basic (53.43s)
--- FAIL: TestAccServiceCatalogProvisionedProduct_disappears (53.46s)
--- FAIL: TestAccServiceCatalogProvisionedProduct_tags (56.03s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	56.088s
FAIL
gmake: *** [GNUmakefile:28: testacc] Error 1

Tests passing after applying fix:

$ gmake testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct' PKG_NAME=internal/service/servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run=TestAccServiceCatalogProvisionedProduct -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (132.79s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (144.50s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (240.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	240.705s

[YakDriver]

Looks good to me! 🎉

Output from acceptance tests (GovCloud):

% TF_ACC=1 go test ./internal/service/servicecatalog -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct' -timeout=180m
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (152.77s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (166.79s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (277.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	278.629s

[github-actions]

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.