Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_accessanalyzer_analyzer: Add test sweeper #21750

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21649.

Output from acceptance testing:

% make sweep SWEEPARGS=-sweep-run=aws_accessanalyzer_analyzer SWEEP=us-west-2 
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_accessanalyzer_analyzer -timeout 60m
2021/11/12 09:29:16 [DEBUG] Running Sweepers for region (us-west-2):
2021/11/12 09:29:16 [DEBUG] Running Sweeper (aws_accessanalyzer_analyzer) in region (us-west-2)
2021/11/12 09:29:16 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/12 09:29:16 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/12 09:29:17 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/12 09:29:18 [DEBUG] Waiting for state to become: [success]
2021/11/12 09:29:18 [DEBUG] Deleting Access Analyzer Analyzer: (tf-acc-test-8360977933789595448)
2021/11/12 09:29:18 [DEBUG] Completed Sweeper (aws_accessanalyzer_analyzer) in region (us-west-2) in 1.894390422s
2021/11/12 09:29:18 Completed Sweepers for region (us-west-2) in 1.894589185s
2021/11/12 09:29:18 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_accessanalyzer_analyzer
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	5.139s

@github-actions github-actions bot added service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Nov 12, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTML! 🎉

@ewbankkit ewbankkit merged commit 0e1f80e into main Nov 13, 2021
@ewbankkit ewbankkit deleted the s-aws_accessanalyzer_analyzer-sweeper branch November 13, 2021 00:15
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 13, 2021
github-actions bot pushed a commit that referenced this pull request Nov 13, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessAnalyzer sweepers
2 participants