data/source_aws_db_snapshot: Avoid nil pointer when snapshot is still being created

[atsushi-ishibashi]

#1794

[atsushi-ishibashi]

This commit set fmt.Sprintf("creating at %s", time.Now().UTC().Format(time.RFC3339)) as snapshot_create_time because snapshot.SnapshotCreateTime is nil under creating. But if snapshot_create_time is important, it should be better to wail until finish.
Depending on the size of DB and region, it may take a long time...

[Ninir]

Hey @atsushi-ishibashi

Thanks for the provided fix. Just left a comment to discuss before taking any action there :)

[Ninir]

In the case where SnapshotCreateTime is nil, the attribute is set as a sentence containing the formatted time: this exposes a wrong information to the end user, and is not consistent with the other case, being just a formatted time.

I think we should only check for the case where it is not nil, because we have the correct snapshot creation time. THoughts? :)

[atsushi-ishibashi]

I agree with you. It's inconsistent with the formatted time.

[Ninir]

LGTM!

Thanks a lot for the work hre @atsushi-ishibashi :)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDbSnapshotDataSource_'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDbSnapshotDataSource_ -timeout 120m
=== RUN   TestAccAWSDbSnapshotDataSource_basic
--- PASS: TestAccAWSDbSnapshotDataSource_basic (594.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	594.890s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!