Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_api_gateway_authorizer: Add support for Cognito User Pool authorizer #2189

Closed
wants to merge 1 commit into from

Conversation

josselin-c
Copy link

WIP/Help Needed

Add support for ProviderARNs parameter for the API Gateway Authorizer object
With this patch it's possible to use a Cognito User Pool as an Authorizer.

API Doc: http://docs.aws.amazon.com/fr_fr/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-authorizer.html

Fix #1106

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 7, 2017
@radeksimko radeksimko added the size/S Managed by automation to categorize the size of a PR. label Nov 15, 2017
@radeksimko
Copy link
Member

Depends on #1419

@radeksimko radeksimko added this to the v1.4.0 milestone Nov 16, 2017
@radeksimko
Copy link
Member

Hi @josselin-c
thanks for raising this PR.

We'll be merging #1419 soon. Do you mind rebasing your branch & adding an acceptance test for this new field after that's done?

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 16, 2017
@josselin-c
Copy link
Author

I rebased my patch over master and now I'm trying to add an acceptance test for the feature.
There is a problem in my code I'm trying to fix:
In func resourceAwsApiGatewayAuthorizerUpdate I don't get how to create a apigateway.PatchOperation when provider_arns changes. A PatchOperation takes a string value but in this case provider_arns is a slice of strings []string. How do you go from []string to string?
Here is the struct definition: https://godoc.org/github.com/aws/aws-sdk-go/service/apigateway#PatchOperation

@josselin-c
Copy link
Author

Anyone can help me on this?

@radeksimko radeksimko added service/apigateway Issues and PRs that pertain to the apigateway service. and removed waiting-response Maintainers are waiting on response from community or contributor. labels Jan 18, 2018
@radeksimko radeksimko changed the title r/api-gateway: add support for Cognito User Pool authorizer resource/aws_api_gateway_authorizer: Add support for Cognito User Pool authorizer Jan 18, 2018
@loivis
Copy link
Contributor

loivis commented Feb 1, 2018

I’ll try to see how to merge my code here later today from #3156

@josselin-c
Copy link
Author

@loivis I can see your PR was way more advanced than mine. I won't mind if you continue with yours. I got my answer reading your patch 👍

@loivis
Copy link
Contributor

loivis commented Feb 1, 2018

@josselin-c Thanks. Would you mind if close this PR and then I'll reopen #3156 ? I haven't tried to commit to other repo thus don't know if I need time to figure that out.

@josselin-c josselin-c closed this Feb 1, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support COGNITO_USER_POOLS authorizer
3 participants