-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecr/lifecycle_policy: Fix diffs when policy equivalent #22142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccECRLifecyclePolicy_ PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRLifecyclePolicy_' -timeout 180m
=== RUN TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== CONT TestAccECRLifecyclePolicy_basic
=== CONT TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRLifecyclePolicy_basic (21.76s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (27.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 33.620s
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21968
Relates #22004
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):