Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_default_vpc and aws_default_subnet: Full lifecycle #22253

Merged
merged 40 commits into from
Jan 21, 2022
Merged

aws_default_vpc and aws_default_subnet: Full lifecycle #22253

merged 40 commits into from
Jan 21, 2022

Commits on Jan 12, 2022

  1. r/aws_default_subnet: Full resource life cycle. First baby steps. 

    Acceptance test output:

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultSubnet_basic -timeout 180m
=== RUN   TestAccEC2DefaultSubnet_basic
=== PAUSE TestAccEC2DefaultSubnet_basic
=== CONT  TestAccEC2DefaultSubnet_basic
    default_subnet_test.go:17: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:

        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_default_subnet.test will be updated in-place
          ~ resource "aws_default_subnet" "test" {
                id                                             = "subnet-5e636b26"
              ~ map_public_ip_on_launch                        = true -> false
                # (15 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccEC2DefaultSubnet_basic (10.19s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        13.707s
FAIL
make: *** [testacc] Error 1
    @ewbankkit
    ewbankkit committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ccd0316 View commit details
    Browse the repository at this point in the history

  2. r/aws_default_subnet: Full resource life cycle. Playing with some ide… 

    …as...

Acceptance test output:

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultSubnet_basic -timeout 180m
=== RUN   TestAccEC2DefaultSubnet_basic
=== PAUSE TestAccEC2DefaultSubnet_basic
=== CONT  TestAccEC2DefaultSubnet_basic
--- PASS: TestAccEC2DefaultSubnet_basic (26.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        29.867s
    @ewbankkit
    ewbankkit committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    da2a7de View commit details
    Browse the repository at this point in the history

  3. r/aws_default_subnet: 'map_public_ip_on_launch' has a Default of true.

    @ewbankkit
    ewbankkit committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    a56deb0 View commit details
    Browse the repository at this point in the history

  4. Additional 'modifySubnetAttriute' functions.

    @ewbankkit
    ewbankkit committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    c7e39fc View commit details
    Browse the repository at this point in the history

  5. r/aws_default_subnet: Complete 'modifySubnetAttributesOnCreate'. 

    Acceptance test output:

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultSubnet_basic -timeout 180m
=== RUN   TestAccEC2DefaultSubnet_basic
=== PAUSE TestAccEC2DefaultSubnet_basic
=== CONT  TestAccEC2DefaultSubnet_basic
--- PASS: TestAccEC2DefaultSubnet_basic (16.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        20.128s
% make testacc TESTARGS='-run=TestAccEC2Subnet_' PKG=ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5  -run=TestAccEC2Subnet_ -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_enableIPv6
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_enableDNS64
--- PASS: TestAccEC2Subnet_basic (36.19s)
=== CONT  TestAccEC2Subnet_outpost
--- PASS: TestAccEC2Subnet_ipv6Native (36.51s)
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (0.62s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.55s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (0.60s)
=== CONT  TestAccEC2Subnet_disappears
--- PASS: TestAccEC2Subnet_disappears (27.28s)
=== CONT  TestAccEC2Subnet_availabilityZoneID
--- PASS: TestAccEC2Subnet_availabilityZoneID (31.74s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEC2Subnet_enableIPv6 (105.09s)
=== CONT  TestAccEC2Subnet_ipv6
--- PASS: TestAccEC2Subnet_enableDNS64 (123.19s)
=== CONT  TestAccEC2Subnet_ignoreTags
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (110.55s)
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (77.30s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (181.07s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (2.01s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2Subnet_ignoreTags (63.57s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2Subnet_ipv6 (105.70s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (77.98s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (62.21s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (72.81s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (83.96s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (60.94s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (80.64s)
--- PASS: TestAccEC2Subnet_tags (77.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        328.734s
    @ewbankkit
    ewbankkit committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cb7abb3 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. r/aws_default_subnet: Set tags on resource Create. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultSubnet_basic -timeout 180m
=== RUN   TestAccEC2DefaultSubnet_basic
=== PAUSE TestAccEC2DefaultSubnet_basic
=== CONT  TestAccEC2DefaultSubnet_basic
--- PASS: TestAccEC2DefaultSubnet_basic (14.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        18.126s
    @ewbankkit
    ewbankkit committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7c7c8f2 View commit details
    Browse the repository at this point in the history

  2. r/aws_default_subnet: Corrections after some testing. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultSubnet_basic -timeout 180m
=== RUN   TestAccEC2DefaultSubnet_basic
=== PAUSE TestAccEC2DefaultSubnet_basic
=== CONT  TestAccEC2DefaultSubnet_basic
--- PASS: TestAccEC2DefaultSubnet_basic (14.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        18.662s
% make testacc TESTARGS='-run=TestAccEC2Subnet_' PKG=ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5  -run=TestAccEC2Subnet_ -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.37s)
=== CONT  TestAccEC2Subnet_disappears
--- PASS: TestAccEC2Subnet_disappears (23.43s)
=== CONT  TestAccEC2Subnet_availabilityZoneID
--- PASS: TestAccEC2Subnet_basic (27.28s)
=== CONT  TestAccEC2Subnet_enableIPv6
--- PASS: TestAccEC2Subnet_ipv6Native (28.20s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (0.61s)
=== CONT  TestAccEC2Subnet_enableDNS64
--- PASS: TestAccEC2Subnet_availabilityZoneID (27.75s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1254: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.56s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccEC2Subnet_ipv6 (88.78s)
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
--- PASS: TestAccEC2Subnet_enableIPv6 (86.63s)
=== CONT  TestAccEC2Subnet_ignoreTags
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (61.66s)
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
--- PASS: TestAccEC2Subnet_enableDNS64 (108.53s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (166.30s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (1.07s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2Subnet_ignoreTags (53.90s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (64.59s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (98.55s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (57.14s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (43.11s)
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (56.84s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (47.42s)
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (62.50s)
--- PASS: TestAccEC2Subnet_tags (63.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        261.856s
    @ewbankkit
    ewbankkit committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5eca053 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. 'setting' -> 'modifying' in error messages.

    @ewbankkit
    ewbankkit committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    83c730c View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. first draft 

    Signed-off-by: Andrea Quintino <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4709245 View commit details
    Browse the repository at this point in the history

  2. ok 

    Signed-off-by: Andrea Quintino <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    d0e1a8d View commit details
    Browse the repository at this point in the history

  3. test ok. manage destroy 

    Signed-off-by: Andrea Quintino <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    b558e87 View commit details
    Browse the repository at this point in the history

  4. test ok. destroy ok 

    Signed-off-by: Andrea Quintino <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ea4a97e View commit details
    Browse the repository at this point in the history

  5. test ok. destroy ok 

    Signed-off-by: Andrea Quintino <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c7c5086 View commit details
    Browse the repository at this point in the history

  6. updated doc 

    Signed-off-by: dirk39 <andreaquin1990@gmail.com>
    @dirk39 @ewbankkit
    dirk39 authored and ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    294ce62 View commit details
    Browse the repository at this point in the history

  7. Revert "updated doc" 

    This reverts commit 068311abc61af4ed43c841ffbce2b70690aec271.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    89da20c View commit details
    Browse the repository at this point in the history

  8. Revert "test ok. destroy ok" 

    This reverts commit 8d7b56c2e0058c52a14008d5ffdd8fdee46318c4.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    f5e87b6 View commit details
    Browse the repository at this point in the history

  9. Revert "test ok. destroy ok" 

    This reverts commit b415b4808674068c3631f21ae4e4170aeb85720c.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c5f180a View commit details
    Browse the repository at this point in the history

  10. Revert "test ok. manage destroy" 

    This reverts commit 972ff5e0e36be04287a5091bd2d5c58c87564618.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    94480a5 View commit details
    Browse the repository at this point in the history

  11. Revert "ok" 

    This reverts commit d74c36cdc05338b62c02df5244661e38ade6b4ab.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    76ded69 View commit details
    Browse the repository at this point in the history

  12. Revert "first draft" 

    This reverts commit 484f2921324b8fb202f396a8ac99d85bafa6d429.
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3bd4f02 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/f-aws_default_subnet-full-lifecy… 

    …cle' into HEAD
    @ewbankkit
    ewbankkit committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    77dd449 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. r/aws_default_vpc: Don't reuse ResourceVPC's schema. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2DefaultVPC_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultVPC_basic -timeout 180m
=== RUN   TestAccEC2DefaultVPC_basic
=== PAUSE TestAccEC2DefaultVPC_basic
=== CONT  TestAccEC2DefaultVPC_basic
--- PASS: TestAccEC2DefaultVPC_basic (21.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	25.294s
    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    bc4b7ec View commit details
    Browse the repository at this point in the history

  2. Tidy up subnet and VPC sweepers.

    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    696e236 View commit details
    Browse the repository at this point in the history

  3. r/aws_default_vpc: IPv6 changes. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2DefaultVPC_basic' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultVPC_basic -timeout 180m
=== RUN   TestAccEC2DefaultVPC_basic
=== PAUSE TestAccEC2DefaultVPC_basic
=== CONT  TestAccEC2DefaultVPC_basic
--- PASS: TestAccEC2DefaultVPC_basic (21.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	24.967s
    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    ce2565f View commit details
    Browse the repository at this point in the history

  4. r/aws_default_vpc: Test IPv6 changes. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock -timeout 180m
=== RUN   TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock
=== CONT  TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccEC2DefaultVPC_assignGeneratedIPv6CIDRBlock (32.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.501s
    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    e63704e View commit details
    Browse the repository at this point in the history

  5. r/aws_default_vpc and r/aws_default_subnet: Serialize tests. 

    Acceptance test output:

% make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/assignGeneratedIPv6CIDRBlock
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (63.64s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (14.60s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/basic (14.60s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (49.04s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/basic (18.14s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/assignGeneratedIPv6CIDRBlock (30.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	67.232s
    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    c056f79 View commit details
    Browse the repository at this point in the history

  6. Store any new IPv6 CIDR block association ID to state.

    @ewbankkit
    ewbankkit committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    031d7c1 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Add 'testAccPreCheckDefaultVPCAvailable'.

    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    45232e4 View commit details
    Browse the repository at this point in the history

  2. Add 'testAccPreCheckDefaultSubnetAvailable'.

    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    ed52198 View commit details
    Browse the repository at this point in the history

  3. r/aws_default_vpc and r/aws_default_subnet: Check existence in TestCa… 

    …se.CheckDestroy.

Acceptance test output:

% make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/assignGeneratedIPv6CIDRBlock
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/basic
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (89.54s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (72.98s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/basic (41.84s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/assignGeneratedIPv6CIDRBlock (31.14s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (16.56s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/basic (16.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	93.528s
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    bd7bc22 View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    8d2ce20 View commit details
    Browse the repository at this point in the history

  5. d/aws_vpcs: Return empty list when no VPCs match. 

    % make testacc TESTARGS='-run=TestAccEC2VPCsDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCsDataSource_ -timeout 180m
=== RUN   TestAccEC2VPCsDataSource_basic
=== PAUSE TestAccEC2VPCsDataSource_basic
=== RUN   TestAccEC2VPCsDataSource_tags
=== PAUSE TestAccEC2VPCsDataSource_tags
=== RUN   TestAccEC2VPCsDataSource_filters
=== PAUSE TestAccEC2VPCsDataSource_filters
=== RUN   TestAccEC2VPCsDataSource_empty
=== PAUSE TestAccEC2VPCsDataSource_empty
=== CONT  TestAccEC2VPCsDataSource_basic
=== CONT  TestAccEC2VPCsDataSource_filters
=== CONT  TestAccEC2VPCsDataSource_empty
=== CONT  TestAccEC2VPCsDataSource_tags
--- PASS: TestAccEC2VPCsDataSource_empty (11.70s)
--- PASS: TestAccEC2VPCsDataSource_basic (22.28s)
--- PASS: TestAccEC2VPCsDataSource_tags (23.42s)
--- PASS: TestAccEC2VPCsDataSource_filters (23.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.424s
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    90c87c9 View commit details
    Browse the repository at this point in the history

  6. EC2: 'testCheckResourceAttrGreaterThanValue' -> 'acctest.CheckResourc… 

    …eAttrGreaterThanValue'.
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    2b20775 View commit details
    Browse the repository at this point in the history

  7. EKS: 'testCheckResourceAttrGreaterThanValue' -> 'acctest.CheckResourc… 

    …eAttrGreaterThanValue'.
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    dc19d47 View commit details
    Browse the repository at this point in the history

  8. r/aws_default_subnet: Add 'testAccEC2DefaultSubnet_privateDnsNameOpti… 

    …onsOnLaunch'.

% make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (48.51s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (48.51s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch (48.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.165s
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    b0fcb35 View commit details
    Browse the repository at this point in the history

  9. r/aws_default_vpc: Add force_destroy and create new tests. 

    % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/VPC PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/VPC'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic
    default_vpc_test.go:56: Deleting existing default VPC: vpc-0952d31628cc2a7ba
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock
    default_vpc_test.go:56: Deleting existing default VPC: vpc-07b89ae85c358b75f
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy
    default_vpc_test.go:56: Deleting existing default VPC: vpc-0599d53adb4a24651
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (203.38s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (203.38s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (22.97s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (33.03s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (50.79s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (25.39s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (36.82s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (34.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	207.630s
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    d7f831c View commit details
    Browse the repository at this point in the history

  10. r/aws_default_subnet: Additional tests. 

    % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (150.53s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (150.53s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (29.08s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (28.64s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (92.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	154.075s
    @ewbankkit
    ewbankkit committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    89b98dd View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. r/aws_default_subnet: Ensure default subnets are recreated. 

    % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (192.57s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (192.57s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (49.32s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (33.13s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (19.62s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (90.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	199.777s
    @ewbankkit
    ewbankkit committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    91a74c4 View commit details
    Browse the repository at this point in the history

  2. r/aws_default_subnet & r/aws_default_vpc: Don't run acceptance tests … 

    …in the standard region(s) as other resources' tests (e.g. aws_instance) implicitly use default subnets.

Acceptance test output:

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic
    default_vpc_test.go:61: Deleting existing default VPC: vpc-070f87de6a2504c87
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock
    default_vpc_test.go:61: Deleting existing default VPC: vpc-08068b0353ebbae41
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy
    default_vpc_test.go:61: Deleting existing default VPC: vpc-09610d2f3e1ffba00
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0a60a9666d2edfb92
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0d5b5572150325e38
    default_subnet_test.go:62: Deleting existing default subnet: subnet-055f31bb2650e3b86
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native
    default_subnet_test.go:62: Deleting existing default subnet: subnet-07b62a14e35e531c8
    default_subnet_test.go:62: Deleting existing default subnet: subnet-03e145e9e3a5db6e6
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0e2ba115852876dc6
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (467.10s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (233.68s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (46.26s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (32.89s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (52.24s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (27.52s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (40.93s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (33.84s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (233.42s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (22.89s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (64.95s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (41.24s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic (21.50s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native (64.50s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (18.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	470.792s
    @ewbankkit
    ewbankkit committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    78cb7c6 View commit details
    Browse the repository at this point in the history

  3. Documentation updates.

    @ewbankkit
    ewbankkit committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d79cf7e View commit details
    Browse the repository at this point in the history