Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only logging argument #22599

Merged
merged 7 commits into from
Feb 7, 2022
Merged

r/s3_bucket: read-only logging argument #22599

merged 7 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 14, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (14.78s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (168.58s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (166.48s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (168.05s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (167.91s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (168.18s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (102.32s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (15.07s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (98.83s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (98.62s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (153.67s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (236.27s)

--- PASS: TestAccS3BucketDataSource_basic (87.40s)
--- PASS: TestAccS3BucketDataSource_website (87.20s)

--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (382.30s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (100.87s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (87.85s)

--- PASS: TestAccS3BucketInventory_basic (101.10s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (100.30s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (100.27s)

--- PASS: TestAccS3BucketMetric_basic (95.17s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (15.38s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (165.10s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (165.09s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (162.74s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (163.97s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (165.16s)

--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (115.77s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (100.99s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (126.62s)
--- PASS: TestAccS3BucketNotification_queue (127.67s)
--- PASS: TestAccS3BucketNotification_topic (99.94s)
--- PASS: TestAccS3BucketNotification_update (181.88s)

--- PASS: TestAccS3BucketObjectDataSource_allParams (86.49s)
--- PASS: TestAccS3BucketObjectDataSource_basic (87.17s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (85.69s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (87.27s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (86.62s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (155.75s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (157.55s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (88.96s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (86.35s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (87.04s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (85.60s)

--- PASS: TestAccS3BucketObject_acl (247.88s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (88.78s)
--- PASS: TestAccS3BucketObject_content (100.44s)
--- PASS: TestAccS3BucketObject_contentBase64 (87.25s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (91.70s)
--- PASS: TestAccS3BucketObject_empty (99.68s)
--- PASS: TestAccS3BucketObject_etagEncryption (102.58s)
--- PASS: TestAccS3BucketObject_ignoreTags (160.50s)
--- PASS: TestAccS3BucketObject_kms (102.17s)
--- PASS: TestAccS3BucketObject_metadata (243.76s)
--- PASS: TestAccS3BucketObject_noNameNoKey (22.70s)
--- PASS: TestAccS3BucketObject_nonVersioned (99.27s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (88.93s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (232.11s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (161.38s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (234.48s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (304.73s)
--- PASS: TestAccS3BucketObject_source (103.33s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (173.90s)
--- PASS: TestAccS3BucketObject_sse (103.10s)
--- PASS: TestAccS3BucketObject_storageClass (391.86s)
--- PASS: TestAccS3BucketObject_tags (309.71s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (305.02s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (316.65s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (303.64s)
--- PASS: TestAccS3BucketObject_updateSameFile (162.94s)
--- PASS: TestAccS3BucketObject_updates (177.22s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (175.10s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (167.65s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (89.80s)

--- PASS: TestAccS3BucketObjectsDataSource_all (163.71s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (163.96s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (163.26s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (163.77s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (163.40s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (164.13s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (165.05s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (171.15s)

--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (77.14s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (178.81s)
--- PASS: TestAccS3BucketOwnershipControls_basic (103.05s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (90.08s)

--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (368.80s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (273.46s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (287.48s)

--- PASS: TestAccS3BucketPolicy_basic (102.48s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (183.07s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (75.66s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (102.56s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (249.10s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (247.44s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (89.32s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (248.85s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (247.47s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (537.57s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (491.49s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (477.93s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (141.64s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (358.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (360.25s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (404.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (404.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (399.03s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (400.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (395.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (364.62s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (233.91s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (405.36s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (312.84s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (401.10s)

--- PASS: TestAccS3BucketVersioning_MFADelete (66.95s)
--- PASS: TestAccS3BucketVersioning_basic (92.83s)
--- PASS: TestAccS3BucketVersioning_disappears (85.25s)
--- PASS: TestAccS3BucketVersioning_update (139.35s)

--- PASS: TestAccS3Bucket_Basic_acceleration (69.02s)
--- PASS: TestAccS3Bucket_Basic_basic (58.50s)
--- PASS: TestAccS3Bucket_Basic_emptyString (56.01s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (92.78s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (90.26s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (89.22s)
--- PASS: TestAccS3Bucket_Basic_generatedName (37.72s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (67.82s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (38.50s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (62.36s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (46.46s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (72.86s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (221.53s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (168.24s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (98.28s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (84.69s)
--- PASS: TestAccS3Bucket_Manage_objectLock (147.94s)
--- PASS: TestAccS3Bucket_Manage_versioning (154.99s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (75.17s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (68.92s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (251.29s)
--- PASS: TestAccS3Bucket_Replication_basic (293.40s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (74.62s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (161.50s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (162.30s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (221.38s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (212.94s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (293.34s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (110.01s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (161.91s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (154.24s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (156.42s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (73.54s)
--- PASS: TestAccS3Bucket_Security_corsDelete (67.75s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (84.70s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (152.59s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (133.35s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (55.45s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (52.48s)
--- PASS: TestAccS3Bucket_Security_grantToACL (80.73s)
--- PASS: TestAccS3Bucket_Security_policy (97.24s)
--- PASS: TestAccS3Bucket_Security_updateACL (60.79s)
--- PASS: TestAccS3Bucket_Security_updateGrant (107.23s)
--- PASS: TestAccS3Bucket_Tags_basic (37.79s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (57.79s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (131.62s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (169.38s)
--- PASS: TestAccS3Bucket_Web_redirect (161.89s)
--- PASS: TestAccS3Bucket_Web_routingRules (97.19s)
--- PASS: TestAccS3Bucket_Web_simple (149.98s)

--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.03s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 14, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 14, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 14, 2022 23:12
anGie44 added a commit that referenced this pull request Jan 15, 2022
@anGie44
Update CHANGELOG for #22599
30e36aa
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 26, 2022

Preceded by #22608

@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 30e36aa to 465945f Compare January 26, 2022 22:48
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 465945f to 22082b7 Compare January 27, 2022 01:14
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 22082b7 to 8fae338 Compare January 27, 2022 01:17
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 02:21
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 8fae338 to 8e6fa47 Compare January 27, 2022 06:21
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22599
5f57f48
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 8e6fa47 to 5f57f48 Compare January 27, 2022 06:24
@anGie44 anGie44 force-pushed the release/4.x branch 4 times, most recently from e604544 to 18688a6 Compare January 28, 2022 22:24
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
anGie44
anGie44 commented Feb 2, 2022
View reviewed changes
.changelog/22599.txt Outdated Show resolved Hide resolved
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22599
f8fe86a
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from 3eb3181 to fd4c8bf Compare February 3, 2022 18:26
@gdavison gdavison self-assigned this Feb 4, 2022
gdavison
gdavison approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (115.35s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (117.38s)
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (120.58s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (121.05s)
--- PASS: TestAccS3BucketVersioning_MFADelete (134.46s)
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (135.65s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (137.24s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (137.74s)
--- PASS: TestAccS3BucketVersioning_disappears (138.15s)
--- PASS: TestAccS3BucketVersioning_basic (142.68s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (143.59s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (152.57s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (223.74s)
--- PASS: TestAccS3Bucket_Manage_objectLock (225.02s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (112.81s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (240.91s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (248.84s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (121.40s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (151.50s)
--- PASS: TestAccS3Bucket_Security_corsDelete (123.73s)
--- PASS: TestAccS3BucketVersioning_update (354.13s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (238.84s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (233.85s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (238.68s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (149.74s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (236.61s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (145.23s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (139.00s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (388.34s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (251.40s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (142.95s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (100.29s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (247.56s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (324.00s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (145.52s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (141.14s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (140.11s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (393.47s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (397.52s)
--- PASS: TestAccS3Bucket_Manage_versioning (245.68s)
--- PASS: TestAccS3Bucket_Security_grantToACL (195.85s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (213.14s)
--- PASS: TestAccS3Bucket_Basic_generatedName (123.03s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (198.21s)
--- PASS: TestAccS3Bucket_Security_updateACL (203.54s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (118.00s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (205.48s)
--- PASS: TestAccS3Bucket_Tags_basic (117.68s)
--- FAIL: TestAccS3Bucket_Tags_ignoreTags (99.76s)
--- PASS: TestAccS3Bucket_Basic_acceleration (197.09s)
--- PASS: TestAccS3Bucket_Basic_emptyString (99.51s)
--- PASS: TestAccS3Bucket_Basic_basic (100.96s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (644.44s)
--- PASS: TestAccS3Bucket_Security_policy (267.41s)
--- PASS: TestAccS3Bucket_Security_updateGrant (272.69s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (102.24s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyArn (99.58s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_disappears (90.38s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (101.02s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (102.73s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (107.86s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (106.09s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (109.78s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (190.41s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (193.42s)
--- PASS: TestAccS3Bucket_Replication_basic (642.20s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (202.22s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (802.44s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (317.68s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (254.70s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (360.68s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (96.66s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (233.03s)
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (31.90s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (125.88s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (31.12s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (109.55s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (34.64s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (96.37s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (84.88s)
--- PASS: TestAccS3BucketPolicy_basic (20.40s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (38.10s)
--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (19.52s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (37.49s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (20.24s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (387.50s)
--- PASS: TestAccS3BucketOwnershipControls_basic (28.52s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (84.85s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (94.81s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (44.05s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (47.69s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (391.95s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (395.11s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (48.29s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (388.02s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (382.43s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (58.57s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (387.76s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (386.24s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (58.03s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (170.23s)
--- PASS: TestAccS3BucketObjectsDataSource_all (70.34s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (378.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (376.73s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (51.30s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (72.16s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (54.01s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (474.94s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (52.42s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (357.34s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (90.01s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (443.41s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (443.49s)
--- PASS: TestAccS3BucketObject_ignoreTags (112.45s)
--- SKIP: TestAccS3BucketObject_nonVersioned (0.00s)
--- PASS: TestAccS3BucketObject_bucketObjectBucket (135.67s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (410.90s)
--- PASS: TestAccS3BucketObject_sse (88.92s)
--- PASS: TestAccS3BucketObject_kms (88.69s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (130.99s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (86.30s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (153.75s)
--- PASS: TestAccS3BucketObject_contentBase64 (85.93s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (197.14s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (200.81s)
--- PASS: TestAccS3BucketObject_noNameNoKey (18.02s)
--- PASS: TestAccS3BucketObject_updateSameFile (152.57s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (160.32s)
--- PASS: TestAccS3BucketObject_etagEncryption (98.27s)
--- PASS: TestAccS3BucketObject_content (98.52s)
--- PASS: TestAccS3BucketObject_source (97.82s)
--- PASS: TestAccS3BucketObject_updates (168.32s)
--- PASS: TestAccS3BucketObject_metadata (218.84s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (251.09s)
--- PASS: TestAccS3BucketObject_acl (227.86s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (164.99s)
--- PASS: TestAccS3BucketObject_empty (105.04s)
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (89.73s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (274.89s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (273.79s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (85.75s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (281.04s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (102.85s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (90.89s)
--- PASS: TestAccS3BucketObject_tags (295.64s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (92.74s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (87.84s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (86.08s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (91.47s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (91.51s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (88.38s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (12.94s)
--- PASS: TestAccS3BucketObjectDataSource_basic (85.80s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (146.07s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (147.36s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (175.07s)
--- PASS: TestAccS3BucketObject_storageClass (352.20s)
--- PASS: TestAccS3BucketNotification_topic (95.36s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (99.60s)
--- PASS: TestAccS3BucketNotification_eventbridge (90.84s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (115.16s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (112.91s)
--- PASS: TestAccS3BucketNotification_queue (132.77s)
--- PASS: TestAccS3BucketMetric_basic (94.98s)
--- PASS: TestAccS3BucketLogging_disappears (87.33s)
--- PASS: TestAccS3BucketNotification_update (190.59s)
--- PASS: TestAccS3BucketLogging_basic (104.80s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (156.46s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (157.18s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (161.34s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (164.70s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (155.84s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (75.53s)
--- PASS: TestAccS3BucketInventory_basic (72.03s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (64.08s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (77.03s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (71.00s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (214.96s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (221.99s)
--- PASS: TestAccS3BucketLogging_update (218.59s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (215.14s)
--- PASS: TestAccS3BucketDataSource_basic (46.94s)
--- PASS: TestAccS3BucketDataSource_website (48.38s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (50.45s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (54.09s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (7.98s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (216.24s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (43.20s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (220.54s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (9.57s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (51.14s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (215.15s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (214.66s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (55.13s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (275.37s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (196.11s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (61.40s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (197.89s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (274.52s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (61.87s)
--- PASS: TestAccS3BucketLifecycleConfiguration_FilterWithPrefix (254.99s)
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (63.51s)
--- PASS: TestAccS3BucketCorsConfiguration_update (136.56s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (98.37s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (97.96s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (219.11s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (97.88s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (97.72s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (96.11s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (82.74s)
--- PASS: TestAccS3BucketAccelerateConfiguration_update (78.03s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (98.21s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (290.13s)

TestAccS3Bucket_Tags_ignoreTags is an intermittent failure (#22953)

anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44
Update CHANGELOG for #22599
f0306f6
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from fee3773 to e158014 Compare February 5, 2022 04:16
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 5, 2022

Output of updated acceptance tests:

--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- PASS: TestAccS3BucketLogging_disappears (30.33s)
--- PASS: TestAccS3BucketLogging_basic (32.73s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (84.40s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (86.08s)
--- PASS: TestAccS3BucketLogging_update (90.05s)

@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from cb7c9cf to 3801d4b Compare February 6, 2022 22:06
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 6, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-deprecation branch from c6ee156 to dddc66b Compare February 6, 2022 22:53
@anGie44 anGie44 merged commit bf0db4e into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-logging-deprecation branch February 7, 2022 00:05
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
Update CHANGELOG.md for #22599
d8161f4
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @gdavison @ewbankkit