resource/aws_security_group: Avoid dropping group from state on AWS consistency issues

[carlossg]

It appears, based on the report in hashicorp/terraform#6991
that the EC2 API is being
inconsistent in reporting that a security group exists shortly after it
has been created; we've seen Terraform get past the "Waiting for
Security Group to exist" step but then apparently detect that it's gone
again once we get into the Update function.

Rewrite of hashicorp/terraform#11361

[DzmitrySudnik]

@carlossg are you still working on it? that issue hit me recently

[carlossg]

I'm not working on it anymore, the change used to work in previous versions of terraform

[copumpkin]

@radeksimko any feedback on this? It's biting me too and I'd love to see it get merged

[bcornils]

looks like we have a check failing. Has anyone had time to assess or review criticality of the failure?

[bflad]

Hi folks 👋 It looks like this old PR was failing TravisCI and did not receive any further attention so I'm going to close this. If this is still an issue, I'd double check that you're on the latest version of the AWS provider.

Nowadays we usually implement resource.Retry() combined with d.IsNewResource() for this type of eventual consistency logic and very much try to avoid Update after Create to simplify the logic. If someone has the interest in adding that but cannot figure out the implementation, please reach out.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!