-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/lambda: tech debt: fix V001 linter errors #23149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccLambdaPermission_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaPermission_' -timeout 180m
=== RUN TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== RUN TestAccLambdaPermission_StatementID_duplicate
=== PAUSE TestAccLambdaPermission_StatementID_duplicate
=== RUN TestAccLambdaPermission_withRawFunctionName
=== PAUSE TestAccLambdaPermission_withRawFunctionName
=== RUN TestAccLambdaPermission_withStatementIdPrefix
=== PAUSE TestAccLambdaPermission_withStatementIdPrefix
=== RUN TestAccLambdaPermission_withQualifier
=== PAUSE TestAccLambdaPermission_withQualifier
=== RUN TestAccLambdaPermission_disappears
=== PAUSE TestAccLambdaPermission_disappears
=== RUN TestAccLambdaPermission_multiplePerms
=== PAUSE TestAccLambdaPermission_multiplePerms
=== RUN TestAccLambdaPermission_withS3
=== PAUSE TestAccLambdaPermission_withS3
=== RUN TestAccLambdaPermission_withSNS
=== PAUSE TestAccLambdaPermission_withSNS
=== RUN TestAccLambdaPermission_withIAMRole
=== PAUSE TestAccLambdaPermission_withIAMRole
=== CONT TestAccLambdaPermission_basic
=== CONT TestAccLambdaPermission_disappears
=== CONT TestAccLambdaPermission_withIAMRole
=== CONT TestAccLambdaPermission_StatementID_duplicate
=== CONT TestAccLambdaPermission_withRawFunctionName
=== CONT TestAccLambdaPermission_withSNS
=== CONT TestAccLambdaPermission_withStatementIdPrefix
=== CONT TestAccLambdaPermission_withS3
=== CONT TestAccLambdaPermission_multiplePerms
=== CONT TestAccLambdaPermission_withQualifier
--- PASS: TestAccLambdaPermission_withS3 (48.94s)
--- PASS: TestAccLambdaPermission_basic (58.19s)
--- PASS: TestAccLambdaPermission_multiplePerms (77.96s)
--- PASS: TestAccLambdaPermission_withStatementIdPrefix (86.26s)
--- PASS: TestAccLambdaPermission_withRawFunctionName (91.46s)
--- PASS: TestAccLambdaPermission_withQualifier (98.66s)
--- PASS: TestAccLambdaPermission_withIAMRole (105.05s)
--- PASS: TestAccLambdaPermission_StatementID_duplicate (111.57s)
--- PASS: TestAccLambdaPermission_withSNS (123.53s)
--- PASS: TestAccLambdaPermission_disappears (127.33s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 131.170s
@megubyte Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #11872
Output from acceptance testing: