Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/lambda: tech debt: fix V001 linter errors #23149

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

melamity
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872

Output from acceptance testing:

--- PASS: TestAccLambdaPermission_withS3 (82.21s)
--- PASS: TestAccLambdaPermission_withIAMRole (100.22s)
--- PASS: TestAccLambdaPermission_withQualifier (111.20s)
--- PASS: TestAccLambdaPermission_withStatementIdPrefix (117.18s)
--- PASS: TestAccLambdaPermission_basic (125.70s)
--- PASS: TestAccLambdaPermission_StatementID_duplicate (126.32s)
--- PASS: TestAccLambdaPermission_multiplePerms (130.97s)
--- PASS: TestAccLambdaPermission_withRawFunctionName (142.99s)
--- PASS: TestAccLambdaPermission_withSNS (173.44s)
--- PASS: TestAccLambdaPermission_disappears (208.43s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 12, 2022
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 13, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccLambdaPermission_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaPermission_'  -timeout 180m
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== RUN   TestAccLambdaPermission_StatementID_duplicate
=== PAUSE TestAccLambdaPermission_StatementID_duplicate
=== RUN   TestAccLambdaPermission_withRawFunctionName
=== PAUSE TestAccLambdaPermission_withRawFunctionName
=== RUN   TestAccLambdaPermission_withStatementIdPrefix
=== PAUSE TestAccLambdaPermission_withStatementIdPrefix
=== RUN   TestAccLambdaPermission_withQualifier
=== PAUSE TestAccLambdaPermission_withQualifier
=== RUN   TestAccLambdaPermission_disappears
=== PAUSE TestAccLambdaPermission_disappears
=== RUN   TestAccLambdaPermission_multiplePerms
=== PAUSE TestAccLambdaPermission_multiplePerms
=== RUN   TestAccLambdaPermission_withS3
=== PAUSE TestAccLambdaPermission_withS3
=== RUN   TestAccLambdaPermission_withSNS
=== PAUSE TestAccLambdaPermission_withSNS
=== RUN   TestAccLambdaPermission_withIAMRole
=== PAUSE TestAccLambdaPermission_withIAMRole
=== CONT  TestAccLambdaPermission_basic
=== CONT  TestAccLambdaPermission_disappears
=== CONT  TestAccLambdaPermission_withIAMRole
=== CONT  TestAccLambdaPermission_StatementID_duplicate
=== CONT  TestAccLambdaPermission_withRawFunctionName
=== CONT  TestAccLambdaPermission_withSNS
=== CONT  TestAccLambdaPermission_withStatementIdPrefix
=== CONT  TestAccLambdaPermission_withS3
=== CONT  TestAccLambdaPermission_multiplePerms
=== CONT  TestAccLambdaPermission_withQualifier
--- PASS: TestAccLambdaPermission_withS3 (48.94s)
--- PASS: TestAccLambdaPermission_basic (58.19s)
--- PASS: TestAccLambdaPermission_multiplePerms (77.96s)
--- PASS: TestAccLambdaPermission_withStatementIdPrefix (86.26s)
--- PASS: TestAccLambdaPermission_withRawFunctionName (91.46s)
--- PASS: TestAccLambdaPermission_withQualifier (98.66s)
--- PASS: TestAccLambdaPermission_withIAMRole (105.05s)
--- PASS: TestAccLambdaPermission_StatementID_duplicate (111.57s)
--- PASS: TestAccLambdaPermission_withSNS (123.53s)
--- PASS: TestAccLambdaPermission_disappears (127.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	131.170s

@ewbankkit
Copy link
Contributor

@megubyte Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c4a1315 into hashicorp:main Feb 13, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 13, 2022
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants