Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to aws-sdk-go@v1.12.34 #2447

Conversation

atsushi-ishibashi
Copy link
Contributor

@atsushi-ishibashi atsushi-ishibashi commented Nov 27, 2017

govendor fetch github.com/aws/aws-sdk-go/....@v1.12.34 didn't fetch new files😕
So additionally I ran the below commands

govendor fetch github.com/aws/aws-sdk-go/service/mediastore@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/medialive@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediaconvert@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediapackage@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediastoredata@v1.12.34

@radeksimko radeksimko added the dependencies Used to indicate dependency changes. label Nov 29, 2017
@Ninir
Copy link
Contributor

Ninir commented Nov 29, 2017

@radeksimko shouldn't this be closed since the merge of #2465?

@atsushi-ishibashi also, the commands you additionally ran are expected: you want to include new services that were not yet registered in the vendor.json file.

The below would only update the vendor.json file for the Go SDK using tag 1.12.34 (but will not fetch any new service added since then):

govendor fetch github.com/aws/aws-sdk-go/....@v1.12.34

So to add those new services, this is indeed the commands you ran, i.e:

govendor fetch github.com/aws/aws-sdk-go/service/mediastore@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/medialive@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediaconvert@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediapackage@v1.12.34
govendor fetch github.com/aws/aws-sdk-go/service/mediastoredata@v1.12.34

Thus, can you rebase against master & rerun the 5 above with the 1.12.35 tag?

Thanks!

@atsushi-ishibashi
Copy link
Contributor Author

@Ninir Creating new branch is easier than resolving conflicts with rebasing so please check out #2481 and close this PR:bow:

@apricote apricote mentioned this pull request Nov 30, 2017
@radeksimko
Copy link
Member

#2481 was merged, so I'm going to close this. Thanks for the PR.

@radeksimko radeksimko closed this Nov 30, 2017
@atsushi-ishibashi atsushi-ishibashi deleted the vendor-aws-sdk-v1.12.34 branch December 13, 2017 15:15
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants