r/ecs_service: retry WaitUntilServicesStable up to 3 times within resource instead of client connection
#24541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anGie44
changed the title
WaitUntilServicesStable up to 3 times within resource instead of client connection
github-actions
bot
added
client-connections
anGie44
force-pushed
the
b-ecs-service-wait-till-active-retry-handling
branch
from
b04fb6f
to
6ea6f18
Compare
ewbankkit
approved these changes
May 5, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-short -run=TestAccECSService_' PKG=ecs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 2 -short -run=TestAccECSService_ -timeout 180m
=== RUN TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN TestAccECSService_CapacityProviderStrategy_multiple
=== PAUSE TestAccECSService_CapacityProviderStrategy_multiple
=== RUN TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN TestAccECSService_renamedCluster
=== PAUSE TestAccECSService_renamedCluster
=== RUN TestAccECSService_healthCheckGracePeriodSeconds
service_test.go:319: skipping long-running test in short mode
--- SKIP: TestAccECSService_healthCheckGracePeriodSeconds (0.00s)
=== RUN TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
service_test.go:420: skipping long-running test in short mode
--- SKIP: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (0.00s)
=== RUN TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN TestAccECSService_ServiceRegistries_changes
service_test.go:1111: skipping long-running test in short mode
--- SKIP: TestAccECSService_ServiceRegistries_changes (0.00s)
=== RUN TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT TestAccECSService_basic
=== CONT TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_basic (90.08s)
=== CONT TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_forceNewDeployment (105.49s)
=== CONT TestAccECSService_executeCommand
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (43.56s)
=== CONT TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_executeCommand (89.92s)
=== CONT TestAccECSService_Tags_managed
--- PASS: TestAccECSService_Tags_propagate (95.85s)
=== CONT TestAccECSService_Tags_basic
--- PASS: TestAccECSService_Tags_managed (70.55s)
=== CONT TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSService_Tags_basic (97.60s)
=== CONT TestAccECSService_ServiceRegistries_basic
--- PASS: TestAccECSService_ServiceRegistries_container (154.33s)
=== CONT TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_replicaSchedulingStrategy (71.10s)
=== CONT TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_ServiceRegistries_basic (169.54s)
=== CONT TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (40.07s)
=== CONT TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_LaunchTypeEC2_network (78.51s)
=== CONT TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_LaunchTypeFargate_basic (155.32s)
=== CONT TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (168.99s)
=== CONT TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (170.62s)
=== CONT TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (83.44s)
=== CONT TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (87.73s)
=== CONT TestAccECSService_iamRole
--- PASS: TestAccECSService_iamRole (72.32s)
=== CONT TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSService_multipleTargetGroups (297.17s)
=== CONT TestAccECSService_alb
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (745.21s)
=== CONT TestAccECSService_clusterName
--- PASS: TestAccECSService_clusterName (70.90s)
=== CONT TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_alb (294.56s)
=== CONT TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSService_deploymentCircuitBreaker (93.20s)
=== CONT TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (72.62s)
=== CONT TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_loadBalancerChanges (259.70s)
=== CONT TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_DeploymentValues_basic (72.06s)
=== CONT TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_DeploymentControllerType_external (44.24s)
=== CONT TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (150.31s)
=== CONT TestAccECSService_renamedCluster
--- PASS: TestAccECSService_renamedCluster (80.62s)
=== CONT TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (308.45s)
=== CONT TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_familyAndRevision (81.46s)
=== CONT TestAccECSService_CapacityProviderStrategy_multiple
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (72.35s)
=== CONT TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_CapacityProviderStrategy_update (363.63s)
=== CONT TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (1.82s)
=== CONT TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (225.18s)
=== CONT TestAccECSService_disappears
--- PASS: TestAccECSService_disappears (80.89s)
=== CONT TestAccECSService_basicImport
--- PASS: TestAccECSService_basicImport (90.99s)
=== CONT TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_PlacementStrategy_basic (133.44s)
=== CONT TestAccECSService_CapacityProviderStrategy_multiple
testing_new.go:79: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Error deleting security group: DependencyViolation: resource sg-0eb6fafdb46ea6958 has a dependent object
status code: 400, request id: 10440f45-1d82-4b6b-a4a2-e7b14fa05e0e
--- FAIL: TestAccECSService_CapacityProviderStrategy_multiple (1004.47s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ecs 3222.217s
FAIL
make: *** [testacc] Error 1Failure is unrelated to this change.
|
This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #20452 (comment)
Output from acceptance testing: