Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set platform override in imagebuilder container recipe. #24712

Closed
wants to merge 31 commits into from
Closed

Set platform override in imagebuilder container recipe. #24712

wants to merge 31 commits into from

Commits on Jul 13, 2022

  1. Set platform override in imagebuilder container recipe.

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    95b1cd9 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    eabdcf0 View commit details
    Browse the repository at this point in the history

  3. Update the docs about platform_override attribute

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ccd3acd View commit details
    Browse the repository at this point in the history

  4. Update internal/service/imagebuilder/container_recipe.go 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b059433 View commit details
    Browse the repository at this point in the history

  5. Update internal/service/imagebuilder/container_recipe.go 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    25b4dd2 View commit details
    Browse the repository at this point in the history

  6. Update website/docs/r/imagebuilder_container_recipe.html.markdown 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    779e15f View commit details
    Browse the repository at this point in the history

  7. Check if ECR Image is in an environment variable. Otherwise skip test.

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4df5df5 View commit details
    Browse the repository at this point in the history

  8. Update component for windows

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    5762ad6 View commit details
    Browse the repository at this point in the history

  9. Separate the linux and windows testing because they can conflict with… 

    … the same ECR image
    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f607feb View commit details
    Browse the repository at this point in the history

  10. Use separate env vars for linux vs windows

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f12b687 View commit details
    Browse the repository at this point in the history

  11. Attempt to use image_os_version_override with createimagerecipe

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ad65eeb View commit details
    Browse the repository at this point in the history

  12. Add docs about image_os_version_override

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c016265 View commit details
    Browse the repository at this point in the history

  13. Use the OS version full text

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    38e93f0 View commit details
    Browse the repository at this point in the history

  14. Remove DiffSuppressFunc as it doesn't do what I expect

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0a94e17 View commit details
    Browse the repository at this point in the history

  15. Update importer to use StateContext

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a331bca View commit details
    Browse the repository at this point in the history

  16. Ignore image_os_version_override in import diff

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    20986ca View commit details
    Browse the repository at this point in the history

  17. Create a negative test for improperly using image builder parent imag… 

    …e with platform override
    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    bb99c3b View commit details
    Browse the repository at this point in the history

  18. Test failure if ecr image used but not platform override.

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    162378e View commit details
    Browse the repository at this point in the history

  19. More windows tests

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    7fb2777 View commit details
    Browse the repository at this point in the history

  20. Similar to image_os_version_override ignore the platform_override in … 

    …all tests of importing container recipe state.
    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1de8dd8 View commit details
    Browse the repository at this point in the history

  21. Remove changes that are not needed

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6eb99e7 View commit details
    Browse the repository at this point in the history

  22. Update internal/acctest/acctest.go 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    796361a View commit details
    Browse the repository at this point in the history

  23. Update .changelog/24712.txt 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ece8417 View commit details
    Browse the repository at this point in the history

  24. Revert change

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f9ec7dd View commit details
    Browse the repository at this point in the history

  25. Update internal/acctest/acctest.go 

    Co-authored-by: Matthew Burgess <549318+mattburgess@users.noreply.github.com>
    @chrisgilmerproj @mattburgess
    chrisgilmerproj and mattburgess committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1e2b08b View commit details
    Browse the repository at this point in the history

  26. Format

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    33e76b1 View commit details
    Browse the repository at this point in the history

  27. Remove extra platform check

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8434592 View commit details
    Browse the repository at this point in the history

  28. Use proper test pattern for expecting errors

    @chrisgilmerproj
    chrisgilmerproj committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    449a6f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. merge main

    @chrisgilmerproj
    chrisgilmerproj committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    1092b7a View commit details
    Browse the repository at this point in the history

  2. Remove duplicate platform override

    @chrisgilmerproj
    chrisgilmerproj committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e1e9a6d View commit details
    Browse the repository at this point in the history

  3. Less changes

    @chrisgilmerproj
    chrisgilmerproj committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    8a52426 View commit details
    Browse the repository at this point in the history