Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lakeformation: Add new aws_lakeformation_resource_lf_tags resource #25565

Merged
merged 15 commits into from
Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/25565.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_lakeformation_resource_lf_tags
```
2 changes: 1 addition & 1 deletion .github/workflows/terraform_provider.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ jobs:
key: ${{ runner.os }}-go-pkg-mod-${{ hashFiles('go.sum') }}
- run: cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
shell: bash
- run: golangci-lint run ./internal/...
- run: golangci-lint run ./internal/... --timeout 75m
ewbankkit marked this conversation as resolved.
Show resolved Hide resolved
shell: bash
- run: cd providerlint && golangci-lint run ./...
shell: bash
Expand Down
1 change: 1 addition & 0 deletions internal/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -1630,6 +1630,7 @@ func Provider() *schema.Provider {
"aws_lakeformation_lf_tag": lakeformation.ResourceLFTag(),
"aws_lakeformation_permissions": lakeformation.ResourcePermissions(),
"aws_lakeformation_resource": lakeformation.ResourceResource(),
"aws_lakeformation_resource_lf_tags": lakeformation.ResourceResourceLFTags(),

"aws_lambda_alias": lambda.ResourceAlias(),
"aws_lambda_code_signing_config": lambda.ResourceCodeSigningConfig(),
Expand Down
7 changes: 7 additions & 0 deletions internal/service/lakeformation/lakeformation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ func TestAccLakeFormation_serial(t *testing.T) {
"disappears": testAccLFTag_disappears,
"values": testAccLFTag_values,
},
"ResourceLFTags": {
"basic": testAccResourceLFTags_basic,
"database": testAccResourceLFTags_database,
"databaseMultiple": testAccResourceLFTags_databaseMultiple,
"table": testAccResourceLFTags_table,
"tableWithColumns": testAccResourceLFTags_tableWithColumns,
},
}

for group, m := range testCases {
Expand Down
2 changes: 1 addition & 1 deletion internal/service/lakeformation/lf_tag_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ resource "aws_lakeformation_data_lake_settings" "test" {

resource "aws_lakeformation_lf_tag" "test" {
key = %[1]q
values = [%s]
values = [%[2]s]
# for consistency, ensure that admins are setup before testing
depends_on = [aws_lakeformation_data_lake_settings.test]
}
Expand Down
Loading