-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore IPv6 Metadata Options and Metadata Tags on aws-iso Partition #25778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @cvockrodt 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Really hoping this can get looked at soon |
bump |
Bump :-) |
Hey @cvockrodt 👋 Thank you very much for taking the time to raise this! With #30545, which was released in |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25227
Checks
conn.Partition
for the current partition, compares with "aws-iso", ignores value forhttp_protocol_ipv6
if match.Not positive that
conn.Partition
is the right thing to doOutput from acceptance testing: