Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore IPv6 Metadata Options and Metadata Tags on aws-iso Partition #25778

Closed
wants to merge 2 commits into from

Conversation

cvockrodt
Copy link

@cvockrodt cvockrodt commented Jul 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25227

Checks conn.Partition for the current partition, compares with "aws-iso", ignores value for http_protocol_ipv6 if match.

Not positive that conn.Partition is the right thing to do

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 11, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cvockrodt 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@cvockrodt cvockrodt changed the title Ignore IPv6 Metadata Options on aws-iso Partition Ignore IPv6 Metadata Options and Metadata Tags on aws-iso Partition Jul 14, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@cvockrodt
Copy link
Author

Really hoping this can get looked at soon

@cvockrodt
Copy link
Author

bump

@jeremymcgee73
Copy link

Bump :-)

@justinretzolk
Copy link
Member

Hey @cvockrodt 👋 Thank you very much for taking the time to raise this! With #30545, which was released in 5.0.0 of the provider, these two values are now Computed, so the defaults won't be passed, which should clear up any issues with the IOS partitions. With that in mind, we'll close this one for now, but again very much appreciate you taking the time to raise this PR 🙂

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpProtocol Metadata Options and Tags Not Supported in All Regions
3 participants