-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding amp workspace datasource #26120
Conversation
This reverts commit ea3f934.
@nicolai86 thoughts? |
let's make sure to carry the right provider name forward in the data source file name as well. |
… a single newline character'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPWorkspaceDataSource_' PKG=amp ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 1 -run=TestAccAMPWorkspaceDataSource_ -timeout 180m
=== RUN TestAccAMPWorkspaceDataSource_basic
--- PASS: TestAccAMPWorkspaceDataSource_basic (19.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 24.085s
@lewinkedrs Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24503.
Output from Datasource (values sanitized):
Output from acceptance testing: