Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_connect_user #26156

Merged
merged 14 commits into from
May 8, 2023
Merged

d/aws_connect_user #26156

merged 14 commits into from
May 8, 2023

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Aug 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21056

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnect_serial/User/dataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnect_serial/User/dataSource -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/User
=== RUN   TestAccConnect_serial/User/dataSource_name
=== RUN   TestAccConnect_serial/User/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyStructure
=== RUN   TestAccConnect_serial/UserHierarchyStructure/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyGroup
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_name
--- PASS: TestAccConnect_serial (457.76s)
    --- PASS: TestAccConnect_serial/User (211.61s)
        --- PASS: TestAccConnect_serial/User/dataSource_name (106.06s)
        --- PASS: TestAccConnect_serial/User/dataSource_id (105.55s)
    --- PASS: TestAccConnect_serial/UserHierarchyStructure (69.87s)
        --- PASS: TestAccConnect_serial/UserHierarchyStructure/dataSource_id (69.87s)
    --- PASS: TestAccConnect_serial/UserHierarchyGroup (176.28s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_id (82.79s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_name (93.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    457.824s

...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Aug 7, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2022
@breathingdust breathingdust added the partner Contribution from a partner. label Mar 15, 2023
@ewbankkit ewbankkit self-assigned this May 8, 2023
# Conflicts:
#	internal/provider/provider.go
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels May 8, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/User/dataSource_' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/User/dataSource_ -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/User
=== RUN   TestAccConnect_serial/User/dataSource_id
=== RUN   TestAccConnect_serial/User/dataSource_name
=== RUN   TestAccConnect_serial/UserHierarchyGroup
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_id
=== RUN   TestAccConnect_serial/UserHierarchyGroup/dataSource_name
=== RUN   TestAccConnect_serial/UserHierarchyStructure
=== RUN   TestAccConnect_serial/UserHierarchyStructure/dataSource_id
--- PASS: TestAccConnect_serial (489.31s)
    --- PASS: TestAccConnect_serial/User (223.63s)
        --- PASS: TestAccConnect_serial/User/dataSource_id (130.55s)
        --- PASS: TestAccConnect_serial/User/dataSource_name (93.08s)
    --- PASS: TestAccConnect_serial/UserHierarchyGroup (181.74s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_id (95.99s)
        --- PASS: TestAccConnect_serial/UserHierarchyGroup/dataSource_name (85.75s)
    --- PASS: TestAccConnect_serial/UserHierarchyStructure (83.93s)
        --- PASS: TestAccConnect_serial/UserHierarchyStructure/dataSource_id (83.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	494.897s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 86f81a8 into hashicorp:main May 8, 2023
@github-actions github-actions bot added this to the v4.67.0 milestone May 8, 2023
@github-actions
Copy link

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new resource/data_source for aws_connect_user
4 participants