Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_macie2_classification_job: Macie2 Add bucket_criteria #26160

Merged

Conversation

nickolivera
Copy link
Contributor

@nickolivera nickolivera commented Aug 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21979.
Closes #19837.
Closes #20162.

Output from acceptance testing:

nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccMacie2_serial/ClassificationJob/bucket_criteria' PKG=macie2 ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/macie2/... -v -count 1 -parallel 1  -run=TestAccMacie2_serial/ClassificationJob/bucket_criteria -timeout 180m
=== RUN   TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationJob
=== RUN   TestAccMacie2_serial/ClassificationJob/bucket_criteria
--- PASS: TestAccMacie2_serial (26.11s)
    --- PASS: TestAccMacie2_serial/ClassificationJob (26.11s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/bucket_criteria (26.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     27.840s
nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccMacie2_serial/ClassificationJob' PKG=macie2 ACCTEST_PARALLELISM=1 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/macie2/... -v -count 1 -parallel 1  -run=TestAccMacie2_serial/ClassificationJob -timeout 180m
=== RUN   TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationJob
=== RUN   TestAccMacie2_serial/ClassificationJob/bucket_criteria
=== RUN   TestAccMacie2_serial/ClassificationJob/basic
=== RUN   TestAccMacie2_serial/ClassificationJob/name_generated
=== RUN   TestAccMacie2_serial/ClassificationJob/name_prefix
=== RUN   TestAccMacie2_serial/ClassificationJob/disappears
=== RUN   TestAccMacie2_serial/ClassificationJob/status
=== RUN   TestAccMacie2_serial/ClassificationJob/complete
=== RUN   TestAccMacie2_serial/ClassificationJob/tags
--- PASS: TestAccMacie2_serial (174.72s)
    --- PASS: TestAccMacie2_serial/ClassificationJob (174.72s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/bucket_criteria (25.85s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/basic (16.46s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_generated (16.28s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_prefix (15.82s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/disappears (15.18s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/status (28.20s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/complete (28.18s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/tags (28.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     176.411s



@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/macie2 Issues and PRs that pertain to the macie2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 8, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 8, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMacie2_serial/ClassificationJob' PKG=macie2      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/ClassificationJob -timeout 180m
=== RUN   TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationJob
=== RUN   TestAccMacie2_serial/ClassificationJob/name_generated
=== RUN   TestAccMacie2_serial/ClassificationJob/name_prefix
=== RUN   TestAccMacie2_serial/ClassificationJob/disappears
=== RUN   TestAccMacie2_serial/ClassificationJob/status
=== RUN   TestAccMacie2_serial/ClassificationJob/complete
=== RUN   TestAccMacie2_serial/ClassificationJob/tags
=== RUN   TestAccMacie2_serial/ClassificationJob/bucket_criteria
=== RUN   TestAccMacie2_serial/ClassificationJob/basic
--- PASS: TestAccMacie2_serial (264.49s)
    --- PASS: TestAccMacie2_serial/ClassificationJob (264.49s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_generated (28.17s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_prefix (24.49s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/disappears (23.31s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/status (42.65s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/complete (43.13s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/tags (42.80s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/bucket_criteria (35.59s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/basic (24.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	270.222s

@ewbankkit
Copy link
Contributor

@nickyamanaka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 568f416 into hashicorp:main Aug 8, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 8, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/macie2 Issues and PRs that pertain to the macie2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants