Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-aws_directconnect_connection_macsec #26274

Merged
merged 31 commits into from
Dec 19, 2022
Merged

f-aws_directconnect_connection_macsec #26274

merged 31 commits into from
Dec 19, 2022

Commits on Sep 15, 2022

  1. First push to add MACSec support

    @ddericco
    Dave DeRicco authored and ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    8d71007 View commit details
    Browse the repository at this point in the history

  2. Add working acceptance tests

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    5c4d093 View commit details
    Browse the repository at this point in the history

  3. Add changelog, run acc test linting

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    6738f1f View commit details
    Browse the repository at this point in the history

  4. [WIP] Add and update docs 

     - Create docs for resource `aws_dx_macsec_key`
 - [WIP] Update existing docs for resource `aws_dx_connection`
    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    a1c5b07 View commit details
    Browse the repository at this point in the history

  5. Minor doc/linting fixes

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    45071a7 View commit details
    Browse the repository at this point in the history

  6. Add support to delete keys on disassociate

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    dd223d2 View commit details
    Browse the repository at this point in the history

  7. Add read function to macsec_key resource

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4ca85df View commit details
    Browse the repository at this point in the history

  8. Update acceptance tests, clean up dx_connection resource

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    96a5dd5 View commit details
    Browse the repository at this point in the history

  9. Minor linting fixes

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c23c8f1 View commit details
    Browse the repository at this point in the history

  10. Add sweeper for aws_dx_macsec_keys, remove secret delete function 

    - Remove default "secret delete" behavior to align with API behavior
- Add sweeper for MACsec keys to clean up dangling acceptance test resources
    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    063abff View commit details
    Browse the repository at this point in the history

  11. Update aws_dx_connection documentation, fix sweeper attribute error

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    810926c View commit details
    Browse the repository at this point in the history

  12. Remove unneeded schema items, fix docs conflict

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    ae5cc7f View commit details
    Browse the repository at this point in the history

  13. Minor linting fixes

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    c12eecc View commit details
    Browse the repository at this point in the history

  14. Additional linting fixes

    @ddericco
    ddericco committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    143007a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Apply code review suggestion: request_macsec attribute 

    Update attribute name to align with API

Co-authored-by: Albert Silva <50742829+silvaalbert@users.noreply.github.com>
    @ddericco @silvaalbert
    ddericco and silvaalbert authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    b07f472 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'hashicorp:main' into f-aws_directconnect_connection-macsec

    @ddericco
    ddericco authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7f5f063 View commit details
    Browse the repository at this point in the history

  3. Add ForceNew to required attribute, remove update Noop

    @ddericco
    ddericco committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a72afad View commit details
    Browse the repository at this point in the history

  4. Add ForceNew to macsec connection, remove check on macsec_capable attr

    @ddericco
    ddericco committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6f984de View commit details
    Browse the repository at this point in the history

  5. Rerun Terrafmt linting

    @ddericco
    ddericco committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    db13c88 View commit details
    Browse the repository at this point in the history

  6. Apply CR suggestion: rename to aws_dx_macsec_key_association 

    Co-authored-by: Albert Silva <50742829+silvaalbert@users.noreply.github.com>
    @ddericco @silvaalbert
    ddericco and silvaalbert authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    047756f View commit details
    Browse the repository at this point in the history

  7. Update internal/provider/provider.go 

    Co-authored-by: Albert Silva <50742829+silvaalbert@users.noreply.github.com>
    @ddericco @silvaalbert
    ddericco and silvaalbert authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8ad97cb View commit details
    Browse the repository at this point in the history

  8. Rename docs, add encryption_mode acc test [WIP]

    @ddericco
    ddericco committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fd0aa9d View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Add skip_destroy argument for aws_dx_connection

    @ddericco
    ddericco committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3e236d9 View commit details
    Browse the repository at this point in the history

  2. WIP - encryption_mode acceptance test

    @ddericco
    ddericco committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    4f71c06 View commit details
    Browse the repository at this point in the history

  3. Tweak CHANGELOG entries.

    @ewbankkit
    ewbankkit committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    63282e5 View commit details
    Browse the repository at this point in the history

  4. Fix semgrep 'dgryski.semgrep-go.oddifsequence.odd-sequence-ifs'.

    @ewbankkit
    ewbankkit committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9da4e2b View commit details
    Browse the repository at this point in the history

  5. Fix golangci-lint 'whitespace'.

    @ewbankkit
    ewbankkit committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3d6318c View commit details
    Browse the repository at this point in the history

  6. Remove unused commented functions

    @ddericco
    ddericco committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    e87145e View commit details
    Browse the repository at this point in the history

  7. Cosmetics.

    @ewbankkit
    ewbankkit committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3f6e762 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Finalize encryption_mode acc test

    @ddericco
    ddericco committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    9e087b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. r/aws_dx_connection: Fix golangci-lint 'unparam'.

    @ewbankkit
    ewbankkit committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1a820f4 View commit details
    Browse the repository at this point in the history