Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector2: New resource aws_inspector2_enabler #27505

Merged
merged 9 commits into from
Oct 27, 2022
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 27, 2022

Description

Relations

Closes #22330

References

Output from Acceptance Testing

% make testacc TESTS="TestAccInspector2Enabler_serial" PKG=inspector2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector2/... -v -count 1 -parallel 20 -run='TestAccInspector2Enabler_serial'  -timeout 180m
=== RUN   TestAccInspector2Enabler_serial
=== RUN   TestAccInspector2Enabler_serial/basic
=== RUN   TestAccInspector2Enabler_serial/accountID
=== RUN   TestAccInspector2Enabler_serial/disappears
--- PASS: TestAccInspector2Enabler_serial (347.03s)
    --- PASS: TestAccInspector2Enabler_serial/basic (105.25s)
    --- PASS: TestAccInspector2Enabler_serial/accountID (187.41s)
    --- PASS: TestAccInspector2Enabler_serial/disappears (54.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector2	348.908s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/inspector2 Issues and PRs that pertain to the inspector2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 27, 2022
@YakDriver YakDriver force-pushed the f-inspector2-enabler branch from 3505e69 to 67c65fc Compare October 27, 2022 05:17
@YakDriver YakDriver merged commit f8b459d into main Oct 27, 2022
@YakDriver YakDriver deleted the f-inspector2-enabler branch October 27, 2022 15:19
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 27, 2022
github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/inspector2 Issues and PRs that pertain to the inspector2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Inspector2 Enable Service Feature
1 participant