Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable gp3 storage_type for aws_db_instance #27670

Merged
merged 21 commits into from
Dec 1, 2022
Merged

enable gp3 storage_type for aws_db_instance #27670

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6c53f0c
enable gp3 storage_type for aws_db_instance
erz4 Nov 6, 2022
e1a6af0
add changelog
erz4 Nov 6, 2022
bc30371
add support of storage_throughput
erz4 Nov 13, 2022
186f5f9
add support of storage_throughput - changelog
erz4 Nov 13, 2022
f8b32c4
add support of storage_throughput - docs
erz4 Nov 13, 2022
f5e0a98
Merge branch 'main' into HEAD
ewbankkit Nov 30, 2022
17f7ec8
Tweak CHANGELOG entries.
ewbankkit Nov 30, 2022
490d31c
r/aws_db_instance: Tweak documentation.
ewbankkit Nov 30, 2022
7300f41
r/aws_db_instance: Use 'storage_throughput' during resource Create an…
ewbankkit Nov 30, 2022
37d09df
d/aws_db_instance: Add 'storage_throughput' attribute.
ewbankkit Nov 30, 2022
fd8c28c
TestAccRDSInstance_basic: Test 'storage_throughput'.
ewbankkit Nov 30, 2022
34df362
TestAccRDSInstance_separateIopsUpdate: Tidy up acceptance test config…
ewbankkit Nov 30, 2022
1b379d9
TestAccRDSInstance_portUpdate: Tidy up acceptance test configuration.
ewbankkit Nov 30, 2022
2b323b2
Add 'TestAccRDSInstance_gp3'.
ewbankkit Nov 30, 2022
0c9596b
Add 'TestAccRDSInstance_storageThroughput'.
ewbankkit Nov 30, 2022
fa4110b
testAccInstanceConfig_orderableClassMySQLGp3 > testAccInstanceConfig_…
erz4 Dec 1, 2022
084a9ac
fix naming convention caps4/5 docs
erz4 Dec 1, 2022
31ac49c
Revert "fix naming convention caps4/5 docs"
ewbankkit Dec 1, 2022
6a2c015
Merge branch 'main' into HEAD
ewbankkit Dec 1, 2022
7fb66cd
Tidy up namescapslist generator.
ewbankkit Dec 1, 2022
f4fc8a7
'testAccInstanceConfig_orderableClassMySQLGp3' -> 'testAccInstanceCon…
ewbankkit Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/27670.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_db_instance: Add 'gp3' option to storage_type argument
```
2 changes: 2 additions & 0 deletions internal/service/rds/consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ const (
const (
storageTypeStandard = "standard"
storageTypeGP2 = "gp2"
storageTypeGP3 = "gp3"
storageTypeIO1 = "io1"
)

func StorageType_Values() []string {
return []string{
storageTypeStandard,
storageTypeGP2,
storageTypeGP3,
storageTypeIO1,
}
}
Expand Down
5 changes: 3 additions & 2 deletions website/docs/r/db_instance.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,9 @@ encrypted. Note that if you are creating a cross-region read replica this field
is ignored and you should instead declare `kms_key_id` with a valid ARN. The
default is `false` if not specified.
* `storage_type` - (Optional) One of "standard" (magnetic), "gp2" (general
purpose SSD), or "io1" (provisioned IOPS SSD). The default is "io1" if `iops` is
specified, "gp2" if not.
purpose SSD), "gp3" (general purpose SSD that needs `iops` independently)
or "io1" (provisioned IOPS SSD). The default is "io1" if `iops` is specified,
"gp2" if not.
* `tags` - (Optional) A map of tags to assign to the resource. If configured with a provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block) present, tags with matching keys will overwrite those defined at the provider-level.
* `timezone` - (Optional) Time zone of the DB instance. `timezone` is currently
only supported by Microsoft SQL Server. The `timezone` can only be set on
Expand Down