Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gp3 support to RDS #27703

Closed
wants to merge 1 commit into from
Closed

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Nov 8, 2022

Description

Relations

Closes #27702

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRDSInstance_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_basic'  -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (507.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        509.327s

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. labels Nov 8, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review November 8, 2022 19:53
@bschaatsbergen bschaatsbergen changed the title Add gp3 EBS support to RDS Add gp3 support to RDS Nov 8, 2022
@justinretzolk
Copy link
Member

Hey @bschaatsbergen 👋 Looks like this is a duplicate of #27670.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 8, 2022
@bschaatsbergen
Copy link
Member Author

Good spot @justinretzolk, closing mine.

@bschaatsbergen bschaatsbergen deleted the rds-gp3 branch November 8, 2022 20:00
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add gp3 storage_type support to aws_db_instance
2 participants