Tech debt: Switch to WithoutTimeout CRUD handlers for MQ
#27989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acceptance test output: % make testacc TESTARGS='-run=TestAccMQConfiguration_' PKG=mq ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQConfiguration_ -timeout 180m === RUN TestAccMQConfiguration_basic === PAUSE TestAccMQConfiguration_basic === RUN TestAccMQConfiguration_withData === PAUSE TestAccMQConfiguration_withData === RUN TestAccMQConfiguration_withLdapData === PAUSE TestAccMQConfiguration_withLdapData === RUN TestAccMQConfiguration_tags === PAUSE TestAccMQConfiguration_tags === CONT TestAccMQConfiguration_basic === CONT TestAccMQConfiguration_withLdapData --- PASS: TestAccMQConfiguration_withLdapData (21.43s) === CONT TestAccMQConfiguration_withData --- PASS: TestAccMQConfiguration_basic (38.58s) === CONT TestAccMQConfiguration_tags --- PASS: TestAccMQConfiguration_withData (19.96s) --- PASS: TestAccMQConfiguration_tags (46.36s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 89.544s
). Acceptance test output: % make testacc TESTARGS='-run=TestAccMQConfiguration_' PKG=mq ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQConfiguration_ -timeout 180m === RUN TestAccMQConfiguration_basic === PAUSE TestAccMQConfiguration_basic === RUN TestAccMQConfiguration_withData === PAUSE TestAccMQConfiguration_withData === RUN TestAccMQConfiguration_withLdapData === PAUSE TestAccMQConfiguration_withLdapData === RUN TestAccMQConfiguration_tags === PAUSE TestAccMQConfiguration_tags === CONT TestAccMQConfiguration_basic === CONT TestAccMQConfiguration_withLdapData --- PASS: TestAccMQConfiguration_withLdapData (25.43s) === CONT TestAccMQConfiguration_withData --- PASS: TestAccMQConfiguration_basic (35.47s) === CONT TestAccMQConfiguration_tags --- PASS: TestAccMQConfiguration_withData (20.19s) --- PASS: TestAccMQConfiguration_tags (47.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 88.212s
…RUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccMQBrokerInstanceTypeOfferingsDataSource_' PKG=mq ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQBrokerInstanceTypeOfferingsDataSource_ -timeout 180m === RUN TestAccMQBrokerInstanceTypeOfferingsDataSource_basic === PAUSE TestAccMQBrokerInstanceTypeOfferingsDataSource_basic === CONT TestAccMQBrokerInstanceTypeOfferingsDataSource_basic --- PASS: TestAccMQBrokerInstanceTypeOfferingsDataSource_basic (18.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 22.768s
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
generators
github-actions
bot
added
service/logs
ewbankkit
added
the
technical-debt
|
This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates MQ service resources to
WithoutTimeoutCRUD handlers.Relations
Relates #15090.
Output from Acceptance Testing