aws_transfer_server - add protocol_details #28621

bennylu2 · 2022-12-31T05:27:41Z

Description

Add protocol_details to aws_transfer_server

Relations

Closes #27695.
Closes #29332.
Relates #26996.

References

https://docs.aws.amazon.com/transfer/latest/userguide/API_ProtocolDetails.html

github-actions · 2022-12-31T05:27:56Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Acceptance test output: % make testacc TESTARGS='-run=TestAccTransfer_serial/Server/basic' PKG=transfer ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/basic -timeout 180m === RUN TestAccTransfer_serial === PAUSE TestAccTransfer_serial === CONT TestAccTransfer_serial === RUN TestAccTransfer_serial/Server === RUN TestAccTransfer_serial/Server/basic --- PASS: TestAccTransfer_serial (201.82s) --- PASS: TestAccTransfer_serial/Server (201.82s) --- PASS: TestAccTransfer_serial/Server/basic (201.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 207.022s % make testacc TESTARGS='-run=TestAccTransfer_serial/Server/ProtocolDetails' PKG=transfer ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/ProtocolDetails -timeout 180m === RUN TestAccTransfer_serial === PAUSE TestAccTransfer_serial === CONT TestAccTransfer_serial === RUN TestAccTransfer_serial/Server === RUN TestAccTransfer_serial/Server/ProtocolDetails --- PASS: TestAccTransfer_serial (200.96s) --- PASS: TestAccTransfer_serial/Server (200.96s) --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (200.96s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 206.064s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server' PKG=transfer 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/APIGateway
=== RUN   TestAccTransfer_serial/Server/ProtocolDetails
=== RUN   TestAccTransfer_serial/Server/Workflow
--- PASS: TestAccTransfer_serial (6760.63s)
    --- PASS: TestAccTransfer_serial/Server (6760.63s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (340.79s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (206.71s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (195.62s)
        --- PASS: TestAccTransfer_serial/Server/Domain (196.87s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (227.90s)
        --- PASS: TestAccTransfer_serial/Server/tags (237.73s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (197.96s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (211.76s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (65.62s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (272.91s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (87.51s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (180.98s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (954.03s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (199.03s)
        --- PASS: TestAccTransfer_serial/Server/VPC (150.62s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (189.48s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (419.05s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (120.77s)
        --- PASS: TestAccTransfer_serial/Server/basic (322.24s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (188.14s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (266.93s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (160.30s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (238.92s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (254.63s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (120.69s)
        --- PASS: TestAccTransfer_serial/Server/disappears (145.66s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (196.30s)
        --- PASS: TestAccTransfer_serial/Server/ProtocolDetails (200.17s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (211.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	6765.840s

ewbankkit · 2023-03-03T21:12:49Z

@bennylu2 Thanks for the contribution 🎉 👏.

github-actions · 2023-03-10T12:45:39Z

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-04-12T02:10:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bennylu2 added 4 commits December 30, 2022 21:15

aws_transfer_server - protocol_details

cfd2686

Update doc

603a327

Add to serial tests

6b0aace

Lint

97192ff

bennylu2 added 3 commits December 30, 2022 21:28

changelog

81319bc

Order

4702aa1

lint

dd56faa

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 31, 2022

ewbankkit added 4 commits March 3, 2023 12:07

Merge branch 'main' into HEAD

fb135d9

Fix providerlint 'S018: schema should use TypeList with MaxItems 1'.

52ad6cf

Update transfer_server.html.markdown

c0c6a7e

ewbankkit approved these changes Mar 3, 2023

View reviewed changes

ewbankkit merged commit 6eb475b into hashicorp:main Mar 7, 2023

github-actions bot added this to the v4.58.0 milestone Mar 7, 2023

ewbankkit mentioned this pull request Mar 20, 2023

fix: correct key in tfMap for AS2 transports #30115

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws_transfer_server - add protocol_details #28621

aws_transfer_server - add protocol_details #28621

bennylu2 commented Dec 31, 2022 •

edited by ewbankkit

Loading

github-actions bot commented Dec 31, 2022

ewbankkit left a comment

ewbankkit commented Mar 3, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Apr 12, 2023

aws_transfer_server - add protocol_details #28621

aws_transfer_server - add protocol_details #28621

Conversation

bennylu2 commented Dec 31, 2022 • edited by ewbankkit Loading

Description

Relations

References

github-actions bot commented Dec 31, 2022

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 3, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Apr 12, 2023

bennylu2 commented Dec 31, 2022 •

edited by ewbankkit

Loading