-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in aws_apprunner_vpc_connector not handling default_tags #28736
Fix bug in aws_apprunner_vpc_connector not handling default_tags #28736
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @tbumi 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppRunnerVPCConnector_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3 -run=TestAccAppRunnerVPCConnector_ -timeout 180m
=== RUN TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== RUN TestAccAppRunnerVPCConnector_defaultTags
=== PAUSE TestAccAppRunnerVPCConnector_defaultTags
=== CONT TestAccAppRunnerVPCConnector_basic
=== CONT TestAccAppRunnerVPCConnector_tags
=== CONT TestAccAppRunnerVPCConnector_defaultTags
--- PASS: TestAccAppRunnerVPCConnector_basic (34.44s)
=== CONT TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_defaultTags (50.07s)
--- PASS: TestAccAppRunnerVPCConnector_disappears (27.36s)
--- PASS: TestAccAppRunnerVPCConnector_tags (73.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 82.970s
@tbumi Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes the bug where
default_tags
from the provider is not handled correctly byaws_apprunner_vpc_connector
Relations
Closes #28634
Output from Acceptance Testing