Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in aws_apprunner_vpc_connector not handling default_tags #28736

Merged

Conversation

tbumi
Copy link
Contributor

@tbumi tbumi commented Jan 6, 2023

Description

Fixes the bug where default_tags from the provider is not handled correctly by aws_apprunner_vpc_connector

Relations

Closes #28634

Output from Acceptance Testing

❯ make testacc PKG=apprunner TESTS=TestAccAppRunnerVPCConnector
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVPCConnector'  -timeout 180m
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== RUN   TestAccAppRunnerVPCConnector_defaultTags
=== PAUSE TestAccAppRunnerVPCConnector_defaultTags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_defaultTags
=== CONT  TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_disappears (78.07s)
--- PASS: TestAccAppRunnerVPCConnector_basic (90.53s)
--- PASS: TestAccAppRunnerVPCConnector_defaultTags (99.82s)
--- PASS: TestAccAppRunnerVPCConnector_tags (155.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	183.850s

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/apprunner Issues and PRs that pertain to the apprunner service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 6, 2023
@tbumi tbumi marked this pull request as ready for review January 6, 2023 12:49
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tbumi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2023
@github-actions github-actions bot removed the tags Pertains to resource tagging. label Jan 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerVPCConnector_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3  -run=TestAccAppRunnerVPCConnector_ -timeout 180m
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== RUN   TestAccAppRunnerVPCConnector_defaultTags
=== PAUSE TestAccAppRunnerVPCConnector_defaultTags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_defaultTags
--- PASS: TestAccAppRunnerVPCConnector_basic (34.44s)
=== CONT  TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_defaultTags (50.07s)
--- PASS: TestAccAppRunnerVPCConnector_disappears (27.36s)
--- PASS: TestAccAppRunnerVPCConnector_tags (73.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	82.970s

@ewbankkit
Copy link
Contributor

@tbumi Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9f5ff3e into hashicorp:main Jan 10, 2023
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 10, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apprunner Issues and PRs that pertain to the apprunner service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_apprunner_vpc_connector doesn't handle default_tags correctly
3 participants