Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kms: Improve diffs for policies #28853

Merged
merged 3 commits into from
Jan 12, 2023
Merged

kms: Improve diffs for policies #28853

merged 3 commits into from
Jan 12, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2023

Description

Relations

Relates #23288

References

Output from Acceptance Testing

% TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 3 -run='TestAccKMSExternalKey_|TestAccKMSKey_'  -timeout 180m
=== RUN   TestAccKMSExternalKey_basic
=== PAUSE TestAccKMSExternalKey_basic
=== RUN   TestAccKMSExternalKey_disappears
=== PAUSE TestAccKMSExternalKey_disappears
=== RUN   TestAccKMSExternalKey_multiRegion
=== PAUSE TestAccKMSExternalKey_multiRegion
=== RUN   TestAccKMSExternalKey_deletionWindowInDays
=== PAUSE TestAccKMSExternalKey_deletionWindowInDays
=== RUN   TestAccKMSExternalKey_description
=== PAUSE TestAccKMSExternalKey_description
=== RUN   TestAccKMSExternalKey_enabled
=== PAUSE TestAccKMSExternalKey_enabled
=== RUN   TestAccKMSExternalKey_keyMaterialBase64
=== PAUSE TestAccKMSExternalKey_keyMaterialBase64
=== RUN   TestAccKMSExternalKey_policy
=== PAUSE TestAccKMSExternalKey_policy
=== RUN   TestAccKMSExternalKey_policyBypass
=== PAUSE TestAccKMSExternalKey_policyBypass
=== RUN   TestAccKMSExternalKey_tags
=== PAUSE TestAccKMSExternalKey_tags
=== RUN   TestAccKMSExternalKey_validTo
=== PAUSE TestAccKMSExternalKey_validTo
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== RUN   TestAccKMSKey_disappears
=== PAUSE TestAccKMSKey_disappears
=== RUN   TestAccKMSKey_multiRegion
=== PAUSE TestAccKMSKey_multiRegion
=== RUN   TestAccKMSKey_asymmetricKey
=== PAUSE TestAccKMSKey_asymmetricKey
=== RUN   TestAccKMSKey_hmacKey
=== PAUSE TestAccKMSKey_hmacKey
=== RUN   TestAccKMSKey_Policy_basic
=== PAUSE TestAccKMSKey_Policy_basic
=== RUN   TestAccKMSKey_Policy_bypass
=== PAUSE TestAccKMSKey_Policy_bypass
=== RUN   TestAccKMSKey_Policy_bypassUpdate
=== PAUSE TestAccKMSKey_Policy_bypassUpdate
=== RUN   TestAccKMSKey_Policy_iamRole
=== PAUSE TestAccKMSKey_Policy_iamRole
=== RUN   TestAccKMSKey_Policy_iamRoleUpdate
=== PAUSE TestAccKMSKey_Policy_iamRoleUpdate
=== RUN   TestAccKMSKey_Policy_iamRoleOrder
=== PAUSE TestAccKMSKey_Policy_iamRoleOrder
=== RUN   TestAccKMSKey_Policy_iamServiceLinkedRole
=== PAUSE TestAccKMSKey_Policy_iamServiceLinkedRole
=== RUN   TestAccKMSKey_Policy_booleanCondition
=== PAUSE TestAccKMSKey_Policy_booleanCondition
=== RUN   TestAccKMSKey_isEnabled
=== PAUSE TestAccKMSKey_isEnabled
=== RUN   TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== CONT  TestAccKMSExternalKey_basic
=== CONT  TestAccKMSKey_multiRegion
=== CONT  TestAccKMSExternalKey_policy
--- PASS: TestAccKMSExternalKey_basic (18.24s)
=== CONT  TestAccKMSKey_disappears
--- PASS: TestAccKMSKey_multiRegion (18.32s)
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_disappears (12.35s)
=== CONT  TestAccKMSExternalKey_validTo
--- PASS: TestAccKMSKey_basic (17.31s)
=== CONT  TestAccKMSExternalKey_tags
--- PASS: TestAccKMSExternalKey_policy (38.08s)
=== CONT  TestAccKMSExternalKey_policyBypass
--- PASS: TestAccKMSExternalKey_policyBypass (21.07s)
=== CONT  TestAccKMSKey_Policy_iamRoleUpdate
--- PASS: TestAccKMSExternalKey_tags (51.81s)
=== CONT  TestAccKMSKey_tags
--- PASS: TestAccKMSKey_Policy_iamRoleUpdate (51.92s)
=== CONT  TestAccKMSKey_isEnabled
--- PASS: TestAccKMSKey_tags (52.86s)
=== CONT  TestAccKMSKey_Policy_booleanCondition
--- PASS: TestAccKMSKey_Policy_booleanCondition (18.94s)
=== CONT  TestAccKMSKey_Policy_iamServiceLinkedRole
--- PASS: TestAccKMSExternalKey_validTo (143.66s)
=== CONT  TestAccKMSKey_Policy_iamRoleOrder
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (63.61s)
=== CONT  TestAccKMSKey_Policy_bypass
--- PASS: TestAccKMSKey_isEnabled (111.93s)
=== CONT  TestAccKMSKey_Policy_iamRole
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (65.39s)
=== CONT  TestAccKMSKey_Policy_bypassUpdate
--- PASS: TestAccKMSKey_Policy_iamRole (42.90s)
=== CONT  TestAccKMSExternalKey_description
--- PASS: TestAccKMSKey_Policy_bypassUpdate (34.62s)
=== CONT  TestAccKMSExternalKey_keyMaterialBase64
--- PASS: TestAccKMSExternalKey_description (40.17s)
=== CONT  TestAccKMSExternalKey_enabled
--- PASS: TestAccKMSKey_Policy_bypass (146.65s)
=== CONT  TestAccKMSKey_hmacKey
--- PASS: TestAccKMSExternalKey_keyMaterialBase64 (103.59s)
=== CONT  TestAccKMSKey_Policy_basic
--- PASS: TestAccKMSKey_hmacKey (13.48s)
=== CONT  TestAccKMSKey_asymmetricKey
--- PASS: TestAccKMSKey_asymmetricKey (13.95s)
=== CONT  TestAccKMSExternalKey_multiRegion
--- PASS: TestAccKMSKey_Policy_basic (35.92s)
=== CONT  TestAccKMSExternalKey_deletionWindowInDays
--- PASS: TestAccKMSExternalKey_multiRegion (20.59s)
=== CONT  TestAccKMSExternalKey_disappears
--- PASS: TestAccKMSExternalKey_disappears (11.72s)
--- PASS: TestAccKMSExternalKey_deletionWindowInDays (27.78s)
--- PASS: TestAccKMSExternalKey_enabled (135.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	443.405s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. labels Jan 12, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 12, 2023
@YakDriver YakDriver merged commit c2d88c9 into main Jan 12, 2023
@YakDriver YakDriver deleted the b-kms-policy-diffs branch January 12, 2023 18:37
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kms Issues and PRs that pertain to the kms service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant