Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam: Provider produced inconsistent final plan #28868

Merged
merged 5 commits into from
Jan 13, 2023
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2023

Description

Relations

Relates #23288

References

Output from Acceptance Testing

% make testacc TESTS="TestAccIAMRolePolicy_|TestAccIAMGroupPolicy_|TestAccIAMRole_InlinePolicy|TestAccIAMUserPolicy_" PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMRolePolicy_|TestAccIAMGroupPolicy_|TestAccIAMRole_InlinePolicy|TestAccIAMUserPolicy_'  -timeout 180m
=== RUN   TestAccIAMGroupPolicy_basic
=== PAUSE TestAccIAMGroupPolicy_basic
=== RUN   TestAccIAMGroupPolicy_disappears
=== PAUSE TestAccIAMGroupPolicy_disappears
=== RUN   TestAccIAMGroupPolicy_namePrefix
=== PAUSE TestAccIAMGroupPolicy_namePrefix
=== RUN   TestAccIAMGroupPolicy_generatedName
=== PAUSE TestAccIAMGroupPolicy_generatedName
=== RUN   TestAccIAMGroupPolicy_unknownsInPolicy
=== PAUSE TestAccIAMGroupPolicy_unknownsInPolicy
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_disappears
=== PAUSE TestAccIAMRolePolicy_disappears
=== RUN   TestAccIAMRolePolicy_policyOrder
=== PAUSE TestAccIAMRolePolicy_policyOrder
=== RUN   TestAccIAMRolePolicy_namePrefix
=== PAUSE TestAccIAMRolePolicy_namePrefix
=== RUN   TestAccIAMRolePolicy_generatedName
=== PAUSE TestAccIAMRolePolicy_generatedName
=== RUN   TestAccIAMRolePolicy_invalidJSON
=== PAUSE TestAccIAMRolePolicy_invalidJSON
=== RUN   TestAccIAMRolePolicy_Policy_invalidResource
=== PAUSE TestAccIAMRolePolicy_Policy_invalidResource
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== RUN   TestAccIAMRole_InlinePolicy_ignoreOrder
=== PAUSE TestAccIAMRole_InlinePolicy_ignoreOrder
=== RUN   TestAccIAMRole_InlinePolicy_empty
=== PAUSE TestAccIAMRole_InlinePolicy_empty
=== RUN   TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
=== RUN   TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== RUN   TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== RUN   TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
=== PAUSE TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
=== RUN   TestAccIAMUserPolicy_basic
=== PAUSE TestAccIAMUserPolicy_basic
=== RUN   TestAccIAMUserPolicy_disappears
=== PAUSE TestAccIAMUserPolicy_disappears
=== RUN   TestAccIAMUserPolicy_namePrefix
=== PAUSE TestAccIAMUserPolicy_namePrefix
=== RUN   TestAccIAMUserPolicy_generatedName
=== PAUSE TestAccIAMUserPolicy_generatedName
=== RUN   TestAccIAMUserPolicy_multiplePolicies
=== PAUSE TestAccIAMUserPolicy_multiplePolicies
=== RUN   TestAccIAMUserPolicy_policyOrder
=== PAUSE TestAccIAMUserPolicy_policyOrder
=== CONT  TestAccIAMGroupPolicy_basic
=== CONT  TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMRolePolicy_policyOrder
=== CONT  TestAccIAMRolePolicy_invalidJSON
=== CONT  TestAccIAMRolePolicy_disappears
=== CONT  TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored
=== CONT  TestAccIAMUserPolicy_basic
=== CONT  TestAccIAMUserPolicy_policyOrder
=== CONT  TestAccIAMUserPolicy_multiplePolicies
=== CONT  TestAccIAMUserPolicy_generatedName
=== CONT  TestAccIAMUserPolicy_namePrefix
=== CONT  TestAccIAMUserPolicy_disappears
=== CONT  TestAccIAMGroupPolicy_namePrefix
=== CONT  TestAccIAMGroupPolicy_unknownsInPolicy
=== CONT  TestAccIAMGroupPolicy_generatedName
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
=== CONT  TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved
=== CONT  TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty
=== CONT  TestAccIAMRolePolicy_generatedName
=== CONT  TestAccIAMRolePolicy_namePrefix
--- PASS: TestAccIAMRolePolicy_invalidJSON (6.03s)
=== CONT  TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack
--- PASS: TestAccIAMUserPolicy_disappears (58.81s)
=== CONT  TestAccIAMRole_InlinePolicy_empty
--- PASS: TestAccIAMRolePolicy_disappears (61.64s)
=== CONT  TestAccIAMRole_InlinePolicy_ignoreOrder
--- PASS: TestAccIAMGroupPolicy_unknownsInPolicy (61.86s)
=== CONT  TestAccIAMGroupPolicy_disappears
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (62.11s)
=== CONT  TestAccIAMRolePolicy_basic
--- PASS: TestAccIAMUserPolicy_policyOrder (84.93s)
=== CONT  TestAccIAMRolePolicy_Policy_invalidResource
--- PASS: TestAccIAMRolePolicy_policyOrder (90.85s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved (109.41s)
--- PASS: TestAccIAMUserPolicy_namePrefix (110.35s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty (110.90s)
--- PASS: TestAccIAMGroupPolicy_namePrefix (115.73s)
--- PASS: TestAccIAMGroupPolicy_generatedName (116.91s)
--- PASS: TestAccIAMUserPolicy_generatedName (116.92s)
--- PASS: TestAccIAMUserPolicy_basic (116.98s)
--- PASS: TestAccIAMRolePolicy_Policy_invalidResource (32.74s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack (111.94s)
--- PASS: TestAccIAMRolePolicy_generatedName (118.01s)
--- PASS: TestAccIAMRolePolicy_namePrefix (118.03s)
--- PASS: TestAccIAMRole_InlinePolicy_empty (59.56s)
--- PASS: TestAccIAMGroupPolicy_disappears (56.68s)
--- PASS: TestAccIAMGroupPolicy_basic (120.58s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored (125.73s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (133.65s)
--- PASS: TestAccIAMRolePolicy_basic (74.14s)
--- PASS: TestAccIAMUserPolicy_multiplePolicies (140.16s)
--- PASS: TestAccIAMRole_InlinePolicy_ignoreOrder (82.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	146.416s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/L Managed by automation to categorize the size of a PR. labels Jan 12, 2023
@YakDriver YakDriver merged commit f16e416 into main Jan 13, 2023
@YakDriver YakDriver deleted the b-iam-policy-fixes branch January 13, 2023 03:30
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 13, 2023
github-actions bot pushed a commit that referenced this pull request Jan 13, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant