service/iam: Import inline IAM user policies on terraform import of IAM user #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
enhancement
erran
changed the title
erran
force-pushed
the
import-iam-user-policy
branch
from
d192116 to
9af872b
Compare
When performing a `terraform import` of a `aws_iam_user` resource now we import state for `aws_iam_user_policy` resources based on the inline policies. This format can be used to import additional aws_iam_user related resources such as managed policy attachments, login profiles, and group associations.
erran
force-pushed
the
import-iam-user-policy
branch
from
9af872b to
5110435
Compare
NOTE: I also fixed the broken testAccCheckIAMUserPolicyDestroy function which was previously checking for a role policy instead of a user policy (which as far as I know would always come back as non-existent).
erran
force-pushed
the
import-iam-user-policy
branch
from
5110435 to
0e311a5
Compare
|
|
erran
commented
Jan 30, 2018
| @@ -208,7 +210,7 @@ func testAccCheckIAMUserPolicyDestroy(s *terraform.State) error { | |||
| } | |||
|
|
|||
| if getResp != nil { | |||
| return fmt.Errorf("Found IAM user policy, expected none: %s", getResp) | |||
| return fmt.Errorf("Found IAM User, expected none: %s", getResp) | |||
There was a problem hiding this comment.
pulled in post-merge, we should remove this.
|
Replaced by #3198. I might create an issue to discuss whether people would like the automatic import of user policies through the iam user resource. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform importof aaws_iam_userresource now we import state foraws_iam_user_policyresources based on the inline policies.aws_iam_user_policyresource using the formatterraform import aws_iam_user_policy.my_policy my_user:my_policy.NOTE: The updated importer for
aws_iam_usermatches the format for importing anaws_s3_bucket. I'm not sure whether we should include this functionality by default. I'd love feedback on whether aimport_inline_iam_user_resourcesor similar provider configuration option would make sense for toggling this behaviour.