Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_ecs_cluster: add capacity_provider attributes #29639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewradamis-paay
Copy link
Contributor

@andrewradamis-paay andrewradamis-paay commented Feb 24, 2023

Description

data-source/aws_ecs_cluster: Add default_capacity_provider_strategy and capacity_providers attributes

Relations

Closes #26533
New workaround for #22823

References

Output from Acceptance Testing

$ make testacc PKG=ecs TESTS=TestAccECSClusterDataSource
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSClusterDataSource'  -timeout 180m
=== RUN   TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN   TestAccECSClusterDataSource_tags
=== PAUSE TestAccECSClusterDataSource_tags
=== RUN   TestAccECSClusterDataSource_ecsClusterCapacityProvider
=== PAUSE TestAccECSClusterDataSource_ecsClusterCapacityProvider
=== CONT  TestAccECSClusterDataSource_ecsCluster
=== CONT  TestAccECSClusterDataSource_tags
=== CONT  TestAccECSClusterDataSource_ecsClusterCapacityProvider
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
--- PASS: TestAccECSClusterDataSource_tags (42.19s)
--- PASS: TestAccECSClusterDataSource_ecsClusterCapacityProvider (42.51s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (43.18s)
--- PASS: TestAccECSClusterDataSource_ecsCluster (43.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        46.490s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 24, 2023
@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch from 23fd3bc to 786fc3f Compare February 24, 2023 18:02
@andrewradamis-paay andrewradamis-paay changed the title d/aws_ecs_cluster: add default_capacity_provider_strategy and capacit… d/aws_ecs_cluster: add capacity_provider attributes Feb 24, 2023
@andrewradamis-paay andrewradamis-paay marked this pull request as ready for review February 24, 2023 18:09
@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch 5 times, most recently from 376fcf8 to efb24fe Compare February 24, 2023 18:19
@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch from efb24fe to 5f64aaf Compare March 20, 2023 21:11
@bbratchiv
Copy link

any plans to merge this PR ?

@1oglop1
Copy link

1oglop1 commented Oct 15, 2023

@ewbankkit Is this something you can review?

@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch from 5f64aaf to d8f00a6 Compare October 17, 2023 16:24
@pazderak
Copy link

👍

@pazderak
Copy link

Hello @andrewradamis-paay - thank you for your work. Would you mind to rebase your MR please?

@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch from d8f00a6 to d442f48 Compare March 14, 2024 21:49
@andrewradamis-paay andrewradamis-paay force-pushed the f-ecs_cluster_data_capacity_providers branch from d442f48 to 58a061f Compare March 14, 2024 21:59
@kg-aws
Copy link

kg-aws commented Jul 24, 2024

Hi @andrewradamis-paay

Thanks a bunch for your contribution! 🙌

I was just wondering if you could rebase your changes to the latest version? That way, we can make sure everything is up-to-date and get another round of reviews and merge sooner now.

Thanks in advance for your help! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ecs_cluster: Update data source to export attribute for defaultCapacityProviderStrategy
5 participants