Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip_destroy support for RDS Option and Parameter Group Resources #29663

Merged
merged 17 commits into from
Aug 8, 2024
Merged

skip_destroy support for RDS Option and Parameter Group Resources #29663

merged 17 commits into from
Aug 8, 2024

Conversation

marco-hoyer
Copy link

Description

This PR adds the skip_destroy property already used in other resources. That comes in handy for situations where users need to keep their RDS Option Groups or Parameter Groups.

In particular I see the issue that if you want to do a DB engine upgrade it requires a new DB Option Group and Parameter Group. TF correctly does all the changes but if apply_immediately is set to false the change is not yet done but scheduled to be carried out during the next maintenance window. Irrespective of that TF will try to delete the old option group and parameter group. This fails because they're still in use by the db. Thus a TF apply will fail until after the next maintenance window of the db.

Another case is about the option group alone. If one creates backups/snapshots of an RDS instance they're directly dependant on the Option Group that was used by the db instance the time when the snapshot was created. When there's an update to a db requiring a replacement of the Option Group resource it will fail until all backups/snapshots were removed. I don't want that. Instead the Option Group should just stay around until it's not needed any more.

Relations

n.a.

References

n.a.

Output from Acceptance Testing

$ make testacc TESTS=TestAccCheckOptionGroup_skipDestroy PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccCheckOptionGroup_skipDestroy'  -timeout 180m
=== RUN   TestAccCheckOptionGroup_skipDestroy
=== PAUSE TestAccCheckOptionGroup_skipDestroy
=== CONT  TestAccCheckOptionGroup_skipDestroy
--- PASS: TestAccCheckOptionGroup_skipDestroy (15.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	22.615s

$ make testacc TESTS=TestAccCheckRDSParameterGroup_skipDestroy PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccCheckRDSParameterGroup_skipDestroy'  -timeout 180m
=== RUN   TestAccCheckRDSParameterGroup_skipDestroy
=== PAUSE TestAccCheckRDSParameterGroup_skipDestroy
=== CONT  TestAccCheckRDSParameterGroup_skipDestroy
--- PASS: TestAccCheckRDSParameterGroup_skipDestroy (15.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	22.683s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Feb 26, 2023
@marco-hoyer
Copy link
Author

Hi all. This is my first contribution here. I hope I got it right so far. If not I'm indeed happy to adopt.

github-actions[bot]
github-actions bot reviewed Feb 26, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @marco-hoyer 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
@jeroenhabets
Copy link

@breathingdust, @solaris-marco now that RDS Postgres 16.1 has been released I stumbled upon the same issue... Any ETA of when this will be merged and released?

@ewbankkit
Merge branch 'main' into HEAD
52740ef 
# Conflicts:
#	internal/service/rds/option_group.go
#	internal/service/rds/option_group_test.go
#	internal/service/rds/parameter_group.go
#	internal/service/rds/parameter_group_test.go
#	website/docs/r/db_option_group.html.markdown
#	website/docs/r/db_parameter_group.html.markdown
@ewbankkit
Add CHANGELOG entries.
8dd1dca
@ewbankkit ewbankkit self-assigned this Aug 6, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 6, 2024
@ewbankkit ewbankkit requested a review from a team as a code owner August 6, 2024 19:27
ewbankkit
ewbankkit approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSOptionGroup_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSOptionGroup_ -timeout 360m
=== RUN   TestAccRDSOptionGroup_basic
=== PAUSE TestAccRDSOptionGroup_basic
=== RUN   TestAccRDSOptionGroup_disappears
=== PAUSE TestAccRDSOptionGroup_disappears
=== RUN   TestAccRDSOptionGroup_nameGenerated
=== PAUSE TestAccRDSOptionGroup_nameGenerated
=== RUN   TestAccRDSOptionGroup_namePrefix
=== PAUSE TestAccRDSOptionGroup_namePrefix
=== RUN   TestAccRDSOptionGroup_tags
=== PAUSE TestAccRDSOptionGroup_tags
=== RUN   TestAccRDSOptionGroup_timeoutBlock
=== PAUSE TestAccRDSOptionGroup_timeoutBlock
=== RUN   TestAccRDSOptionGroup_optionGroupDescription
=== PAUSE TestAccRDSOptionGroup_optionGroupDescription
=== RUN   TestAccRDSOptionGroup_basicDestroyWithInstance
=== PAUSE TestAccRDSOptionGroup_basicDestroyWithInstance
=== RUN   TestAccRDSOptionGroup_Option_optionSettings
=== PAUSE TestAccRDSOptionGroup_Option_optionSettings
=== RUN   TestAccRDSOptionGroup_OptionOptionSettings_iamRole
=== PAUSE TestAccRDSOptionGroup_OptionOptionSettings_iamRole
=== RUN   TestAccRDSOptionGroup_sqlServerOptionsUpdate
=== PAUSE TestAccRDSOptionGroup_sqlServerOptionsUpdate
=== RUN   TestAccRDSOptionGroup_oracleOptionsUpdate
=== PAUSE TestAccRDSOptionGroup_oracleOptionsUpdate
=== RUN   TestAccRDSOptionGroup_OptionOptionSettings_multipleNonDefault
=== PAUSE TestAccRDSOptionGroup_OptionOptionSettings_multipleNonDefault
=== RUN   TestAccRDSOptionGroup_multipleOptions
=== PAUSE TestAccRDSOptionGroup_multipleOptions
=== RUN   TestAccRDSOptionGroup_Tags_withOptions
=== PAUSE TestAccRDSOptionGroup_Tags_withOptions
=== RUN   TestAccRDSOptionGroup_badDiffs
=== PAUSE TestAccRDSOptionGroup_badDiffs
=== RUN   TestAccRDSOptionGroup_skipDestroy
=== PAUSE TestAccRDSOptionGroup_skipDestroy
=== CONT  TestAccRDSOptionGroup_basic
=== CONT  TestAccRDSOptionGroup_OptionOptionSettings_iamRole
=== CONT  TestAccRDSOptionGroup_timeoutBlock
=== CONT  TestAccRDSOptionGroup_Option_optionSettings
--- PASS: TestAccRDSOptionGroup_basic (14.03s)
=== CONT  TestAccRDSOptionGroup_basicDestroyWithInstance
--- PASS: TestAccRDSOptionGroup_timeoutBlock (14.03s)
=== CONT  TestAccRDSOptionGroup_optionGroupDescription
--- PASS: TestAccRDSOptionGroup_OptionOptionSettings_iamRole (23.43s)
=== CONT  TestAccRDSOptionGroup_multipleOptions
--- PASS: TestAccRDSOptionGroup_Option_optionSettings (25.04s)
=== CONT  TestAccRDSOptionGroup_skipDestroy
--- PASS: TestAccRDSOptionGroup_optionGroupDescription (12.62s)
=== CONT  TestAccRDSOptionGroup_badDiffs
--- PASS: TestAccRDSOptionGroup_skipDestroy (9.74s)
=== CONT  TestAccRDSOptionGroup_Tags_withOptions
--- PASS: TestAccRDSOptionGroup_multipleOptions (12.90s)
=== CONT  TestAccRDSOptionGroup_oracleOptionsUpdate
--- PASS: TestAccRDSOptionGroup_badDiffs (26.56s)
=== CONT  TestAccRDSOptionGroup_OptionOptionSettings_multipleNonDefault
--- PASS: TestAccRDSOptionGroup_oracleOptionsUpdate (25.08s)
=== CONT  TestAccRDSOptionGroup_sqlServerOptionsUpdate
--- PASS: TestAccRDSOptionGroup_Tags_withOptions (29.65s)
=== CONT  TestAccRDSOptionGroup_namePrefix
--- PASS: TestAccRDSOptionGroup_OptionOptionSettings_multipleNonDefault (21.53s)
=== CONT  TestAccRDSOptionGroup_tags
--- PASS: TestAccRDSOptionGroup_namePrefix (12.67s)
=== CONT  TestAccRDSOptionGroup_nameGenerated
--- PASS: TestAccRDSOptionGroup_sqlServerOptionsUpdate (21.34s)
=== CONT  TestAccRDSOptionGroup_disappears
--- PASS: TestAccRDSOptionGroup_nameGenerated (12.85s)
--- PASS: TestAccRDSOptionGroup_disappears (10.28s)
--- PASS: TestAccRDSOptionGroup_tags (29.10s)
--- PASS: TestAccRDSOptionGroup_basicDestroyWithInstance (647.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	666.807s
% make testacc TESTARGS='-run=TestAccRDSParameterGroup_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSParameterGroup_ -timeout 360m
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== RUN   TestAccRDSParameterGroup_disappears
=== PAUSE TestAccRDSParameterGroup_disappears
=== RUN   TestAccRDSParameterGroup_tags
=== PAUSE TestAccRDSParameterGroup_tags
=== RUN   TestAccRDSParameterGroup_caseWithMixedParameters
=== PAUSE TestAccRDSParameterGroup_caseWithMixedParameters
=== RUN   TestAccRDSParameterGroup_limit
=== PAUSE TestAccRDSParameterGroup_limit
=== RUN   TestAccRDSParameterGroup_namePrefix
=== PAUSE TestAccRDSParameterGroup_namePrefix
=== RUN   TestAccRDSParameterGroup_generatedName
=== PAUSE TestAccRDSParameterGroup_generatedName
=== RUN   TestAccRDSParameterGroup_withApplyMethod
=== PAUSE TestAccRDSParameterGroup_withApplyMethod
=== RUN   TestAccRDSParameterGroup_only
=== PAUSE TestAccRDSParameterGroup_only
=== RUN   TestAccRDSParameterGroup_matchDefault
=== PAUSE TestAccRDSParameterGroup_matchDefault
=== RUN   TestAccRDSParameterGroup_updateParameters
=== PAUSE TestAccRDSParameterGroup_updateParameters
=== RUN   TestAccRDSParameterGroup_caseParameters
=== PAUSE TestAccRDSParameterGroup_caseParameters
=== RUN   TestAccRDSParameterGroup_skipDestroy
=== PAUSE TestAccRDSParameterGroup_skipDestroy
=== CONT  TestAccRDSParameterGroup_basic
=== CONT  TestAccRDSParameterGroup_withApplyMethod
=== CONT  TestAccRDSParameterGroup_updateParameters
=== CONT  TestAccRDSParameterGroup_skipDestroy
--- PASS: TestAccRDSParameterGroup_skipDestroy (10.48s)
=== CONT  TestAccRDSParameterGroup_caseParameters
--- PASS: TestAccRDSParameterGroup_withApplyMethod (14.11s)
=== CONT  TestAccRDSParameterGroup_limit
--- PASS: TestAccRDSParameterGroup_updateParameters (23.53s)
=== CONT  TestAccRDSParameterGroup_generatedName
--- PASS: TestAccRDSParameterGroup_caseParameters (19.49s)
=== CONT  TestAccRDSParameterGroup_namePrefix
--- PASS: TestAccRDSParameterGroup_basic (32.84s)
=== CONT  TestAccRDSParameterGroup_only
--- PASS: TestAccRDSParameterGroup_generatedName (10.59s)
=== CONT  TestAccRDSParameterGroup_tags
--- PASS: TestAccRDSParameterGroup_limit (24.54s)
=== CONT  TestAccRDSParameterGroup_caseWithMixedParameters
--- PASS: TestAccRDSParameterGroup_namePrefix (10.95s)
=== CONT  TestAccRDSParameterGroup_disappears
--- PASS: TestAccRDSParameterGroup_only (12.32s)
=== CONT  TestAccRDSParameterGroup_matchDefault
--- PASS: TestAccRDSParameterGroup_disappears (10.29s)
--- PASS: TestAccRDSParameterGroup_caseWithMixedParameters (14.03s)
--- PASS: TestAccRDSParameterGroup_matchDefault (12.85s)
--- PASS: TestAccRDSParameterGroup_tags (31.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	69.860s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSGlobalCluster_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSGlobalCluster_ -timeout 720m
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSGlobalCluster_disappears
=== PAUSE TestAccRDSGlobalCluster_disappears
=== RUN   TestAccRDSGlobalCluster_databaseName
=== PAUSE TestAccRDSGlobalCluster_databaseName
=== RUN   TestAccRDSGlobalCluster_deletionProtection
=== PAUSE TestAccRDSGlobalCluster_deletionProtection
=== RUN   TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMinor
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMinor
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMajor
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMajor
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
=== RUN   TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== RUN   TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
=== RUN   TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
=== PAUSE TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
=== RUN   TestAccRDSGlobalCluster_forceDestroy
=== PAUSE TestAccRDSGlobalCluster_forceDestroy
=== RUN   TestAccRDSGlobalCluster_sourceDBClusterIdentifier
=== PAUSE TestAccRDSGlobalCluster_sourceDBClusterIdentifier
=== RUN   TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
=== RUN   TestAccRDSGlobalCluster_storageEncrypted
=== PAUSE TestAccRDSGlobalCluster_storageEncrypted
=== CONT  TestAccRDSGlobalCluster_basic
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion
=== CONT  TestAccRDSGlobalCluster_sourceDBClusterIdentifier
--- PASS: TestAccRDSGlobalCluster_basic (13.75s)
=== CONT  TestAccRDSGlobalCluster_engineLifecycleSupport_disabled
--- PASS: TestAccRDSGlobalCluster_engineLifecycleSupport_disabled (13.67s)
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion
--- PASS: TestAccRDSGlobalCluster_sourceDBClusterIdentifier (179.63s)
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMajor
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajor (1753.18s)
=== CONT  TestAccRDSGlobalCluster_EngineVersion_updateMinor
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMajorMultiRegion (3493.70s)
=== CONT  TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraPostgreSQL (14.65s)
=== CONT  TestAccRDSGlobalCluster_forceDestroy
--- PASS: TestAccRDSGlobalCluster_forceDestroy (11.59s)
=== CONT  TestAccRDSGlobalCluster_storageEncrypted
--- PASS: TestAccRDSGlobalCluster_storageEncrypted (21.88s)
=== CONT  TestAccRDSGlobalCluster_EngineVersion_auroraMySQL
--- PASS: TestAccRDSGlobalCluster_EngineVersion_auroraMySQL (13.84s)
=== CONT  TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinor (1560.94s)
=== CONT  TestAccRDSGlobalCluster_databaseName
--- PASS: TestAccRDSGlobalCluster_databaseName (21.79s)
=== CONT  TestAccRDSGlobalCluster_deletionProtection
--- PASS: TestAccRDSGlobalCluster_SourceDBClusterIdentifier_storageEncrypted (147.78s)
=== CONT  TestAccRDSGlobalCluster_disappears
--- PASS: TestAccRDSGlobalCluster_disappears (11.99s)
--- PASS: TestAccRDSGlobalCluster_deletionProtection (50.46s)
--- PASS: TestAccRDSGlobalCluster_EngineVersion_updateMinorMultiRegion (2973.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	3006.045s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSClusterActivityStream_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSClusterActivityStream_ -timeout 720m
=== RUN   TestAccRDSClusterActivityStream_basic
=== PAUSE TestAccRDSClusterActivityStream_basic
=== RUN   TestAccRDSClusterActivityStream_disappears
=== PAUSE TestAccRDSClusterActivityStream_disappears
=== CONT  TestAccRDSClusterActivityStream_basic
=== CONT  TestAccRDSClusterActivityStream_disappears
--- PASS: TestAccRDSClusterActivityStream_disappears (1930.67s)
--- PASS: TestAccRDSClusterActivityStream_basic (2066.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2071.450s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSCluster_\|TestAccRDSClustersDataSource_\|TestAccRDSClusterDataSource_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSCluster_\|TestAccRDSClustersDataSource_\|TestAccRDSClusterDataSource_ -timeout 720m
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== RUN   TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== PAUSE TestAccRDSClusterDataSource_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_identifierGenerated
=== PAUSE TestAccRDSCluster_identifierGenerated
=== RUN   TestAccRDSCluster_identifierPrefix
=== PAUSE TestAccRDSCluster_identifierPrefix
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_allowMajorVersionUpgrade
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgrade
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
=== RUN   TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
=== RUN   TestAccRDSCluster_onlyMajorVersion
=== PAUSE TestAccRDSCluster_onlyMajorVersion
=== RUN   TestAccRDSCluster_minorVersion
=== PAUSE TestAccRDSCluster_minorVersion
=== RUN   TestAccRDSCluster_availabilityZones
=== PAUSE TestAccRDSCluster_availabilityZones
=== RUN   TestAccRDSCluster_availabilityZones_caCertificateIdentifier
=== PAUSE TestAccRDSCluster_availabilityZones_caCertificateIdentifier
=== RUN   TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN   TestAccRDSCluster_storageTypeIo2
=== PAUSE TestAccRDSCluster_storageTypeIo2
=== RUN   TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN   TestAccRDSCluster_allocatedStorage
=== PAUSE TestAccRDSCluster_allocatedStorage
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== RUN   TestAccRDSCluster_iops
=== PAUSE TestAccRDSCluster_iops
=== RUN   TestAccRDSCluster_dbClusterInstanceClass
=== PAUSE TestAccRDSCluster_dbClusterInstanceClass
=== RUN   TestAccRDSCluster_backtrackWindow
=== PAUSE TestAccRDSCluster_backtrackWindow
=== RUN   TestAccRDSCluster_dbSubnetGroupName
=== PAUSE TestAccRDSCluster_dbSubnetGroupName
=== RUN   TestAccRDSCluster_pointInTimeRestore
=== PAUSE TestAccRDSCluster_pointInTimeRestore
=== RUN   TestAccRDSCluster_pointInTimeRestoreViaResourceID
=== PAUSE TestAccRDSCluster_pointInTimeRestoreViaResourceID
=== RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
=== RUN   TestAccRDSCluster_takeFinalSnapshot
=== PAUSE TestAccRDSCluster_takeFinalSnapshot
=== RUN   TestAccRDSCluster_missingUserNameCausesError
=== PAUSE TestAccRDSCluster_missingUserNameCausesError
=== RUN   TestAccRDSCluster_domain
=== PAUSE TestAccRDSCluster_domain
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_updateIAMRoles
=== PAUSE TestAccRDSCluster_updateIAMRoles
=== RUN   TestAccRDSCluster_kmsKey
=== PAUSE TestAccRDSCluster_kmsKey
=== RUN   TestAccRDSCluster_networkType
=== PAUSE TestAccRDSCluster_networkType
=== RUN   TestAccRDSCluster_encrypted
=== PAUSE TestAccRDSCluster_encrypted
=== RUN   TestAccRDSCluster_copyTagsToSnapshot
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot
=== RUN   TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
=== PAUSE TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
=== RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_backupsUpdate
=== PAUSE TestAccRDSCluster_backupsUpdate
=== RUN   TestAccRDSCluster_iamAuth
=== PAUSE TestAccRDSCluster_iamAuth
=== RUN   TestAccRDSCluster_deletionProtection
=== PAUSE TestAccRDSCluster_deletionProtection
=== RUN   TestAccRDSCluster_engineMode
=== PAUSE TestAccRDSCluster_engineMode
=== RUN   TestAccRDSCluster_engineVersion
=== PAUSE TestAccRDSCluster_engineVersion
=== RUN   TestAccRDSCluster_engineVersionWithPrimaryInstance
=== PAUSE TestAccRDSCluster_engineVersionWithPrimaryInstance
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
=== RUN   TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
=== RUN   TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== PAUSE TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managed
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managed
=== RUN   TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSCluster_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSCluster_port
=== PAUSE TestAccRDSCluster_port
=== RUN   TestAccRDSCluster_scaling
=== PAUSE TestAccRDSCluster_scaling
=== RUN   TestAccRDSCluster_serverlessV2ScalingConfiguration
=== PAUSE TestAccRDSCluster_serverlessV2ScalingConfiguration
=== RUN   TestAccRDSCluster_Scaling_defaultMinCapacity
=== PAUSE TestAccRDSCluster_Scaling_defaultMinCapacity
=== RUN   TestAccRDSCluster_snapshotIdentifier
=== PAUSE TestAccRDSCluster_snapshotIdentifier
=== RUN   TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless
    cluster_test.go:2117: serverless does not support snapshot restore on an empty volume
--- SKIP: TestAccRDSCluster_SnapshotIdentifierEngineMode_serverless (0.00s)
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== RUN   TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== PAUSE TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
=== RUN   TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterPassword
=== RUN   TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_masterUsername
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
=== RUN   TestAccRDSCluster_enableHTTPEndpoint
=== PAUSE TestAccRDSCluster_enableHTTPEndpoint
=== RUN   TestAccRDSCluster_enableHTTPEndpointProvisioned
=== PAUSE TestAccRDSCluster_enableHTTPEndpointProvisioned
=== RUN   TestAccRDSCluster_password
=== PAUSE TestAccRDSCluster_password
=== RUN   TestAccRDSCluster_NoDeleteAutomatedBackups
=== PAUSE TestAccRDSCluster_NoDeleteAutomatedBackups
=== RUN   TestAccRDSCluster_engineLifecycleSupport_disabled
=== PAUSE TestAccRDSCluster_engineLifecycleSupport_disabled
=== RUN   TestAccRDSCluster_performanceInsightsEnabled
=== PAUSE TestAccRDSCluster_performanceInsightsEnabled
=== RUN   TestAccRDSCluster_performanceInsightsKMSKeyID
=== PAUSE TestAccRDSCluster_performanceInsightsKMSKeyID
=== RUN   TestAccRDSCluster_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSCluster_performanceInsightsRetentionPeriod
=== RUN   TestAccRDSCluster_localWriteForwarding
=== PAUSE TestAccRDSCluster_localWriteForwarding
=== RUN   TestAccRDSClustersDataSource_filter
=== PAUSE TestAccRDSClustersDataSource_filter
=== CONT  TestAccRDSClusterDataSource_basic
=== CONT  TestAccRDSCluster_deletionProtection
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSClusterDataSource_basic (152.09s)
=== CONT  TestAccRDSCluster_enableHTTPEndpoint
--- PASS: TestAccRDSCluster_deletionProtection (170.14s)
=== CONT  TestAccRDSClustersDataSource_filter
--- PASS: TestAccRDSClustersDataSource_filter (113.15s)
=== CONT  TestAccRDSCluster_localWriteForwarding
--- PASS: TestAccRDSCluster_localWriteForwarding (123.54s)
=== CONT  TestAccRDSCluster_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (356.25s)
=== CONT  TestAccRDSCluster_performanceInsightsKMSKeyID
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (383.22s)
=== CONT  TestAccRDSCluster_performanceInsightsEnabled
--- PASS: TestAccRDSCluster_performanceInsightsRetentionPeriod (1793.51s)
=== CONT  TestAccRDSCluster_engineLifecycleSupport_disabled
--- PASS: TestAccRDSCluster_performanceInsightsKMSKeyID (1816.27s)
=== CONT  TestAccRDSCluster_NoDeleteAutomatedBackups
--- PASS: TestAccRDSCluster_engineLifecycleSupport_disabled (174.52s)
=== CONT  TestAccRDSCluster_password
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (3740.63s)
=== CONT  TestAccRDSCluster_enableHTTPEndpointProvisioned
--- PASS: TestAccRDSCluster_password (169.16s)
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
--- PASS: TestAccRDSCluster_enableHTTPEndpointProvisioned (142.17s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (160.17s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_performanceInsightsEnabled (2086.67s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (311.64s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (372.09s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_snapshotIdentifier (363.09s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (315.47s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_ManagedMasterPassword_convertToManaged (182.56s)
=== CONT  TestAccRDSCluster_iops
--- PASS: TestAccRDSCluster_port (209.13s)
=== CONT  TestAccRDSCluster_iamAuth
--- PASS: TestAccRDSCluster_scaling (331.24s)
=== CONT  TestAccRDSCluster_backupsUpdate
--- PASS: TestAccRDSCluster_iamAuth (141.76s)
=== CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_backupsUpdate (178.24s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime
--- PASS: TestAccRDSCluster_copyTagsToSnapshot_restorePointInTime (446.27s)
=== CONT  TestAccRDSCluster_copyTagsToSnapshot
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (185.53s)
=== CONT  TestAccRDSCluster_encrypted
--- PASS: TestAccRDSCluster_encrypted (121.74s)
=== CONT  TestAccRDSCluster_networkType
--- PASS: TestAccRDSCluster_networkType (201.32s)
=== CONT  TestAccRDSCluster_kmsKey
--- PASS: TestAccRDSCluster_kmsKey (128.60s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_updateIAMRoles (160.15s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_iops (1789.08s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (246.39s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (131.29s)
=== CONT  TestAccRDSCluster_domain
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2153.19s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (144.39s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (3.83s)
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_pointInTimeRestore (255.03s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
--- PASS: TestAccRDSCluster_dbSubnetGroupName (161.56s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_domain (877.83s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_backtrackWindow (179.12s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_takeFinalSnapshot (284.96s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (1829.94s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (304.79s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (133.97s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2602.72s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (127.35s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2777.62s)
=== CONT  TestAccRDSCluster_onlyMajorVersion
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (181.67s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (191.35s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (3631.47s)
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (172.02s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
--- PASS: TestAccRDSCluster_onlyMajorVersion (877.75s)
=== CONT  TestAccRDSCluster_pointInTimeRestoreViaResourceID
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (122.20s)
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (122.89s)
=== CONT  TestAccRDSCluster_storageTypeIo2
--- PASS: TestAccRDSCluster_pointInTimeRestoreViaResourceID (294.58s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (454.37s)
=== CONT  TestAccRDSCluster_storageTypeIo1
--- PASS: TestAccRDSCluster_allocatedStorage (1567.14s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_encryptedRestore
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (309.24s)
=== CONT  TestAccRDSCluster_availabilityZones_caCertificateIdentifier
--- PASS: TestAccRDSCluster_storageTypeIo2 (1571.76s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_availabilityZones (132.72s)
=== CONT  TestAccRDSCluster_minorVersion
--- PASS: TestAccRDSCluster_storageTypeIo1 (1630.41s)
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_disappears (121.88s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_identifierPrefix (133.85s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_identifierGenerated (144.67s)
=== CONT  TestAccRDSCluster_engineVersionWithPrimaryInstance
--- PASS: TestAccRDSCluster_availabilityZones_caCertificateIdentifier (1549.53s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (168.93s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_minorVersion (1171.35s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterPassword
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (135.22s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (321.33s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_masterUsername
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (392.77s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (354.23s)
=== CONT  TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (322.46s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1222.27s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_engineVersion (429.82s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (571.24s)
=== CONT  TestAccRDSCluster_basic
--- PASS: TestAccRDSCluster_basic (215.03s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (1982.44s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_tags
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2096.97s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (403.57s)
=== CONT  TestAccRDSClusterDataSource_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1798.38s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSClusterDataSource_ManagedMasterPassword_managed (162.57s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (397.36s)
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_tags (138.65s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_engineMode (414.27s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (325.83s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1083.40s)
--- PASS: TestAccRDSCluster_NoDeleteAutomatedBackups (473.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	16168.450s

@ewbankkit
Copy link
Contributor

@marco-hoyer Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 67557b1 into hashicorp:main Aug 8, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@magreenbaum magreenbaum mentioned this pull request Aug 9, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@marco-hoyer @jeroenhabets @ewbankkit @breathingdust @solaris-marco