Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework validators and sweeper helpers #30092

Merged
merged 12 commits into from
Apr 6, 2023
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 17, 2023

Description

Adds timestamp and ARN validators for the framework.
Add UpgradeState() method to framework resource wrapper
Add helper for framework supplemental attributes

Relations

Relates #29135

References

Output from Acceptance Testing

$ go test -count=1 ./internal/framework/... ./internal/verify/... ./internal/types/timestamp/...

?   	github.com/hashicorp/terraform-provider-aws/internal/framework/flex	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework	0.427s
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/boolplanmodifier	0.424s
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/int64planmodifier	0.451s
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/stringplanmodifier	0.159s
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/types	0.751s
ok  	github.com/hashicorp/terraform-provider-aws/internal/framework/validators	1.044s
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	0.887s
ok  	github.com/hashicorp/terraform-provider-aws/internal/types/timestamp	0.458s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added flex Pertains to FLatteners and EXpanders. provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/XL Managed by automation to categorize the size of a PR. labels Mar 17, 2023
@johnsonaj johnsonaj force-pushed the f-framework-validators-sweeper branch from 8b86259 to cfb3948 Compare April 4, 2023 14:08
@github-actions github-actions bot removed the flex Pertains to FLatteners and EXpanders. label Apr 5, 2023
@johnsonaj johnsonaj force-pushed the f-framework-validators-sweeper branch from 81ac6fa to 5c81f2c Compare April 6, 2023 14:29
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit f9f9402 into main Apr 6, 2023
@johnsonaj johnsonaj deleted the f-framework-validators-sweeper branch April 6, 2023 15:16
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants