Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/aws_s3_bucket: Get default encryption configuration #3018

Closed
wants to merge 1 commit into from

Conversation

trung
Copy link
Contributor

@trung trung commented Jan 17, 2018

Clean up commits to replace PR #2300

@trung
Copy link
Contributor Author

trung commented Jan 17, 2018

❯ make testacc TESTARGS="-run=TestAccDataSourceS3Bucket_*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccDataSourceS3Bucket_* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceS3Bucket_basic
--- PASS: TestAccDataSourceS3Bucket_basic (34.82s)
=== RUN   TestAccDataSourceS3Bucket_website
--- PASS: TestAccDataSourceS3Bucket_website (36.52s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionNotEnabled
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionNotEnabled (33.45s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAES256
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAES256 (34.75s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAWSKMS
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAWSKMS (66.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	205.750s

@radeksimko radeksimko added service/s3 Issues and PRs that pertain to the s3 service. enhancement Requests to existing resources that expand the functionality or scope. labels Jan 17, 2018
@radeksimko radeksimko changed the title d/aws_s3_bucket: get default encryption configuration data-source/aws_s3_bucket: Get default encryption configuration Jan 17, 2018
@bflad
Copy link
Contributor

bflad commented Oct 9, 2018

Hi @trung 👋 Can you please explain the use case for retrieving this information from the data source? I'm going to close out this pull request since the original issues were relating to adding support for the resource and have long since been closed, but if there is a valid use case for this, would love to know more and we can revisit. 😄

@bflad bflad closed this Oct 9, 2018
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants