Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AWS SSM Contacts resources #30667

Merged
merged 21 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .changelog/30667.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
```release-note:new-resource
aws_ssmcontacts_contact
```

```release-note:new-data-source
aws_ssmcontacts_contact
```

```release-note:new-resource
aws_ssmcontacts_contact_channel
```

```release-note:new-data-source
aws_ssmcontacts_contact_channel
```

```release-note:new-resource
aws_ssmcontacts_plan
```

```release-note:new-data-source
aws_ssmcontacts_plan
```
15 changes: 15 additions & 0 deletions .ci/.semgrep-service-name0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3390,3 +3390,18 @@ rules:
patterns:
- pattern-regex: "(?i)ComputeOptimizer"
severity: WARNING
- id: configservice-in-func-name
languages:
- go
message: Do not use "ConfigService" in func name inside configservice package
paths:
include:
- internal/service/configservice
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
58 changes: 43 additions & 15 deletions .ci/.semgrep-service-name1.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: configservice-in-func-name
languages:
- go
message: Do not use "ConfigService" in func name inside configservice package
paths:
include:
- internal/service/configservice
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ConfigService"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: configservice-in-test-name
languages:
- go
Expand Down Expand Up @@ -3366,3 +3351,46 @@ rules:
- pattern-not-regex: "^TestAccInspector2"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: inspector2-in-const-name
languages:
- go
message: Do not use "Inspector2" in const name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector2"
severity: WARNING
- id: inspector2-in-var-name
languages:
- go
message: Do not use "Inspector2" in var name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector2"
severity: WARNING
- id: inspectorv2-in-func-name
languages:
- go
message: Do not use "inspectorv2" in func name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)inspectorv2"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
101 changes: 58 additions & 43 deletions .ci/.semgrep-service-name2.yml
Original file line number Diff line number Diff line change
@@ -1,48 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: inspector2-in-const-name
languages:
- go
message: Do not use "Inspector2" in const name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector2"
severity: WARNING
- id: inspector2-in-var-name
languages:
- go
message: Do not use "Inspector2" in var name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Inspector2"
severity: WARNING
- id: inspectorv2-in-func-name
languages:
- go
message: Do not use "inspectorv2" in func name inside inspector2 package
paths:
include:
- internal/service/inspector2
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)inspectorv2"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: inspectorv2-in-const-name
languages:
- go
Expand Down Expand Up @@ -3377,3 +3334,61 @@ rules:
- pattern-regex: "(?i)Redshift"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-test-name
languages:
- go
message: Include "Redshift" in test name
paths:
include:
- internal/service/redshift/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshift"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-const-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
116 changes: 58 additions & 58 deletions .ci/.semgrep-service-name3.yml
Original file line number Diff line number Diff line change
@@ -1,63 +1,5 @@
# Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
rules:
- id: redshift-in-test-name
languages:
- go
message: Include "Redshift" in test name
paths:
include:
- internal/service/redshift/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccRedshift"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: redshift-in-const-name
languages:
- go
message: Do not use "Redshift" in const name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshift-in-var-name
languages:
- go
message: Do not use "Redshift" in var name inside redshift package
paths:
include:
- internal/service/redshift
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)Redshift"
severity: WARNING
- id: redshiftdata-in-func-name
languages:
- go
message: Do not use "RedshiftData" in func name inside redshiftdata package
paths:
include:
- internal/service/redshiftdata
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)RedshiftData"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: redshiftdata-in-test-name
languages:
- go
Expand Down Expand Up @@ -2275,6 +2217,64 @@ rules:
patterns:
- pattern-regex: "(?i)SSM"
severity: WARNING
- id: ssmcontacts-in-func-name
languages:
- go
message: Do not use "SSMContacts" in func name inside ssmcontacts package
paths:
include:
- internal/service/ssmcontacts
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)SSMContacts"
- pattern-not-regex: ^TestAcc.*
severity: WARNING
- id: ssmcontacts-in-test-name
languages:
- go
message: Include "SSMContacts" in test name
paths:
include:
- internal/service/ssmcontacts/*_test.go
patterns:
- pattern: func $NAME( ... ) { ... }
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-not-regex: "^TestAccSSMContacts"
- pattern-regex: ^TestAcc.*
severity: WARNING
- id: ssmcontacts-in-const-name
languages:
- go
message: Do not use "SSMContacts" in const name inside ssmcontacts package
paths:
include:
- internal/service/ssmcontacts
patterns:
- pattern: const $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)SSMContacts"
severity: WARNING
- id: ssmcontacts-in-var-name
languages:
- go
message: Do not use "SSMContacts" in var name inside ssmcontacts package
paths:
include:
- internal/service/ssmcontacts
patterns:
- pattern: var $NAME = ...
- metavariable-pattern:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)SSMContacts"
severity: WARNING
- id: ssmincidents-in-func-name
languages:
- go
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services_all.kt
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ val services = mapOf(
"sns" to ServiceSpec("SNS (Simple Notification)"),
"sqs" to ServiceSpec("SQS (Simple Queue)"),
"ssm" to ServiceSpec("SSM (Systems Manager)", vpcLock = true),
"ssmcontacts" to ServiceSpec("SSM Contacts"),
"ssmincidents" to ServiceSpec("SSM Incident Manager Incidents"),
"ssoadmin" to ServiceSpec("SSO Admin"),
"storagegateway" to ServiceSpec("Storage Gateway", vpcLock = true),
Expand Down
2 changes: 2 additions & 0 deletions internal/provider/service_packages_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading