Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Plugin Framework flattener/expander functions PoC - Phase 2 #32356

Merged
merged 117 commits into from
Aug 17, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 3, 2023

Description

Extends flex.Expand and flex.Flatten to support struct-to-struct copies including nested (slices of) structs.

Relations

Relates #31858.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2InstanceConnectEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2InstanceConnectEndpoint_ -timeout 180m
=== RUN   TestAccEC2InstanceConnectEndpoint_basic
=== PAUSE TestAccEC2InstanceConnectEndpoint_basic
=== RUN   TestAccEC2InstanceConnectEndpoint_disappears
=== PAUSE TestAccEC2InstanceConnectEndpoint_disappears
=== RUN   TestAccEC2InstanceConnectEndpoint_tags
=== PAUSE TestAccEC2InstanceConnectEndpoint_tags
=== RUN   TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== PAUSE TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== CONT  TestAccEC2InstanceConnectEndpoint_basic
=== CONT  TestAccEC2InstanceConnectEndpoint_tags
--- PASS: TestAccEC2InstanceConnectEndpoint_basic (364.53s)
=== CONT  TestAccEC2InstanceConnectEndpoint_securityGroupIDs
--- PASS: TestAccEC2InstanceConnectEndpoint_securityGroupIDs (366.63s)
=== CONT  TestAccEC2InstanceConnectEndpoint_disappears
--- PASS: TestAccEC2InstanceConnectEndpoint_tags (1112.73s)
--- PASS: TestAccEC2InstanceConnectEndpoint_disappears (383.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1119.436s

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 3, 2023
@ewbankkit ewbankkit added the flex Pertains to FLatteners and EXpanders. label Jul 3, 2023
@github-actions github-actions bot removed the flex Pertains to FLatteners and EXpanders. label Jul 5, 2023
@ewbankkit ewbankkit changed the title [WIP] Generic Plugin Framework flattener/expander functions PoC - Phase 2 Generic Plugin Framework flattener/expander functions PoC - Phase 2 Aug 17, 2023
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Aug 17, 2023

% make testacc TESTARGS='-run=TestAccEC2InstanceConnectEndpoint_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2InstanceConnectEndpoint_ -timeout 180m
=== RUN   TestAccEC2InstanceConnectEndpoint_basic
=== PAUSE TestAccEC2InstanceConnectEndpoint_basic
=== RUN   TestAccEC2InstanceConnectEndpoint_disappears
=== PAUSE TestAccEC2InstanceConnectEndpoint_disappears
=== RUN   TestAccEC2InstanceConnectEndpoint_tags
=== PAUSE TestAccEC2InstanceConnectEndpoint_tags
=== RUN   TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== PAUSE TestAccEC2InstanceConnectEndpoint_securityGroupIDs
=== CONT  TestAccEC2InstanceConnectEndpoint_basic
=== CONT  TestAccEC2InstanceConnectEndpoint_tags
--- PASS: TestAccEC2InstanceConnectEndpoint_basic (381.75s)
=== CONT  TestAccEC2InstanceConnectEndpoint_disappears
--- PASS: TestAccEC2InstanceConnectEndpoint_disappears (377.37s)
=== CONT  TestAccEC2InstanceConnectEndpoint_securityGroupIDs
--- PASS: TestAccEC2InstanceConnectEndpoint_securityGroupIDs (365.15s)
--- PASS: TestAccEC2InstanceConnectEndpoint_tags (1136.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1142.641s
% make testacc TESTARGS='-run=TestAccResourceExplorer2_serial/Index' PKG=resourceexplorer2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20  -run=TestAccResourceExplorer2_serial/Index -timeout 180m
=== RUN   TestAccResourceExplorer2_serial
=== PAUSE TestAccResourceExplorer2_serial
=== CONT  TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/Index
=== RUN   TestAccResourceExplorer2_serial/Index/tags
=== RUN   TestAccResourceExplorer2_serial/Index/type
=== RUN   TestAccResourceExplorer2_serial/Index/basic
=== RUN   TestAccResourceExplorer2_serial/Index/disappears
--- PASS: TestAccResourceExplorer2_serial (152.11s)
    --- PASS: TestAccResourceExplorer2_serial/Index (152.11s)
        --- PASS: TestAccResourceExplorer2_serial/Index/tags (60.28s)
        --- PASS: TestAccResourceExplorer2_serial/Index/type (45.17s)
        --- PASS: TestAccResourceExplorer2_serial/Index/basic (26.39s)
        --- PASS: TestAccResourceExplorer2_serial/Index/disappears (20.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2	157.492s

@ewbankkit ewbankkit merged commit 7f7c17a into main Aug 17, 2023
49 checks passed
@ewbankkit ewbankkit deleted the f-further-auto-flex branch August 17, 2023 18:04
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 17, 2023
@ewbankkit
Copy link
Contributor Author

Next phase:

  • Address TODOs in code
  • Use in all new Plugin Framework resources
  • Documentation

@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants