Quicksight: raise limit for maximum allowed visuals per sheet to 50

[denvazh]

Description

This PR corrects number of allowed visuals per sheet in Quicksight analysis and raises limit from 30 to 50.

Relations

Closes #32855

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_SheetDefinition.html#API_SheetDefinition_Contents

Visuals
A list of the visuals that are on a sheet. Visual placement is determined by the layout of the sheet.

Type: Array of Visual objects

Array Members: Maximum number of 50 items.

Required: No

Limit was raised from 30 to 50: https://community.amazonquicksight.com/t/30-visual-limit/2869/16

Output from Acceptance Testing

Unfortunately, I'm not able to run the acceptance tests.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @denvazh 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[github-actions]

Welcome @denvazh 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[denvazh]

(If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

Oops, I did create PR from organization fork and was not really aware of possible problems it could create.
I checked organization configuration, however was unable to find relevant setting. It seems it might not be possible: https://github.com/orgs/community/discussions/5634
If that's a blocker, I can fork as user repository and create PR there instead.

[justinretzolk]

Hey @denvazh 👋 Thank you for taking the time to open this! Don't worry too much about the maintainer edit permissions issue. In that case, if anything needs to be changed afte review, someone on the team would likely just ask you to make any necessary changes rather than doing it themselves.

[jar-b]

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightAnalysis_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightAnalysis_disappears (49.11s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (52.64s)
--- PASS: TestAccQuickSightAnalysis_basic (53.86s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (57.49s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (58.20s)
--- PASS: TestAccQuickSightAnalysis_update (95.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 98.713s

[jar-b]

Thanks for your contribution, @denvazh!

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.