Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: aws_msk_replicator #33973

Merged
merged 22 commits into from
Oct 18, 2023
Merged

New resource: aws_msk_replicator #33973

merged 22 commits into from
Oct 18, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 17, 2023

Description

Adds new resource aws_msk_replicator.

Relations

Closes #33987.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaReplicator_' PKG=kafka ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 2  -run=TestAccKafkaReplicator_ -timeout 720m
=== RUN   TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== RUN   TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== RUN   TestAccKafkaReplicator_tags
=== PAUSE TestAccKafkaReplicator_tags
=== RUN   TestAccKafkaReplicator_disappears
=== PAUSE TestAccKafkaReplicator_disappears
=== CONT  TestAccKafkaReplicator_basic
=== CONT  TestAccKafkaReplicator_tags
--- PASS: TestAccKafkaReplicator_tags (7462.58s)
=== CONT  TestAccKafkaReplicator_disappears
--- PASS: TestAccKafkaReplicator_basic (7462.83s)
=== CONT  TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_disappears (6707.65s)
--- PASS: TestAccKafkaReplicator_update (6770.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	14239.176s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Oct 17, 2023
@ewbankkit ewbankkit changed the title New resource: aws_msk_replicator New resource: aws_msk_replicator Oct 17, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafka Issues and PRs that pertain to the kafka service. generators Relates to code generators. labels Oct 17, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 17, 2023
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 17, 2023
@ewbankkit ewbankkit added the partner Contribution from a partner. label Oct 17, 2023
@ewbankkit
Copy link
Contributor Author

@markoskandylis Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 50bad69 into main Oct 18, 2023
51 checks passed
@ewbankkit ewbankkit deleted the f-msk-replicator branch October 18, 2023 18:43
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 18, 2023
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
@justinretzolk justinretzolk added partner Contribution from a partner. and removed partner Contribution from a partner. labels Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kafka Issues and PRs that pertain to the kafka service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon MSK Replicator
3 participants